1492454 - The "CFR Recommendation" is wrongly displayed more than once during a day, if the browser is restarted

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

Attachment: rec of the issue.gif

[Affected versions]:
- Firefox 63 and above

[Affected Platforms]:
- All Windows
- All Linux
- All Mac

[Prerequisites]:
- Have a Firefox profile with the following prefs in the "about:config" page:
	- "browser.newtabpage.activity-stream.asrouterExperimentEnabled" with "true" value;
	- "browser.newtabpage.activity-stream.asrouter.messageProviders" with "[{"id":"cfr", "cohort": "one_per_day", "frequency": {"custom": [{"period": "daily", "cap": 1}]}, "type":"local","localProvider":"CFRMessageProvider","enabled":true}]" value.
	- "browser.search.region" set to "US";
	- "devtools.chrome.enabled" set to true.
	- Have two "Top Sites" with the "frecency" score at least 10000 (eg. "YouTube" and "Wikipedia").
- Have the "Browser Console" opened.

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites.
2. Open a new tab and click the first "Top Site" from prerequisites.
3. Restart the browser.
4. Open another tab and click the second "Top Site" from prerequisites.
5. Observe the right part of the "Address Bar".

[Expected result]:
- Only the "Page actions", "Save to Pocket" and "Bookmark this page" buttons are displayed.

[Actual result]:
- The "CFR Recommendation" button is also displayed.

[Notes]:
- The "frecency" score is determined by the number of times a website is accessed. If a website is accessed for multiple times will result a higher "frecency" score. Also, it can be verified by typing the following string in the Browser Console: NewTabUtils.activityStreamProvider.getTopFrecentSites({numItems: 25}).then(r => console.log(r.map(s=>`${s.url} [${s.frecency}]`).join('\n'))) .
- This issue is reproducible on all the study's branches.
- Attached a screen recording of the issue.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4441

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/ffc6e2675a0c289402c19a717ed96cc28f1e67b5
Fix Bug 1492454: Normalise ASRouter frequency caps (#4441)

Comment 3

[Kate Hudson :k88hudson]

[Tracking Requested - why for this release]: This is a severe enough bug that users would be getting too many recommendations; we will need to uplift this fix.

Comment 4

[Pascal Chevrel:pascalc]

Tracking as this is blocking a shield study. Please get a patch reviewed, landed and sticking on mozilla-central and then request an uplift of the patch to beta branch thanks.

Comment 5

[Kate Hudson :k88hudson]

Attachment: Bug 1492454 - Normalise ASRouter frequency caps

Comment 6

[Ursula Sarracini (:ursula)]

Comment on attachment 9011056 [details]
Bug 1492454 - Normalise ASRouter frequency caps

Ursula Sarracini (:ursula) has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46e2a6f480a0
Normalise ASRouter frequency caps r=ursula

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/46e2a6f480a0

Comment 9

[Kate Hudson :k88hudson]

Comment on attachment 9011056 [details]
Bug 1492454 - Normalise ASRouter frequency caps

Approval Request Comment
[Feature/Bug causing the regression]: Daily contextual feature recommendation impressions are cleared when the browser restarts, invalidating daily frequency caps
[User impact if declined]: Users will see too many recommendations in one day, potentially causing too much disruption/annoyance
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: On nightly as of Sept. 22 
[Needs manual test from QE? If yes, steps to reproduce]: STR is included in the first comment of this bug
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: The change affects code only running behind a pref/during a study
[String changes made/needed]: None

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9011056 [details]
Bug 1492454 - Normalise ASRouter frequency caps

Thanks, uplift approved for 63 beta 9.

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6ffb05d637a5

Comment 12

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

I have verified that this issue is no longer reproducible on Windows 10 x64, Arch Linux and Mac 10.13.3 with the latest version of Firefox Beta (63.0b9 - Build ID 20180924202103) and latest "Firefox Nightly" (64.0a1 - Build ID 20180924220042) installed. Now the "CFR Recommendations" are displayed only once in a day.