Remove AppCacheUtils from .eslintrc

RESOLVED FIXED in Firefox 64

Status

P4
normal
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: sole, Assigned: dev)

Tracking

({good-first-bug})

unspecified
Firefox 64
good-first-bug

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

This file does not exist anymore in the code base. It was removed in Bug 1469824, but this rule was accidentally left behind.

To fix this bug, the line `"client/shared/AppCacheUtils.jsm",` needs to be removed:
https://dxr.mozilla.org/mozilla-central/source/devtools/.eslintrc.js#93
(Reporter)

Updated

6 months ago
Keywords: good-first-bug
Priority: -- → P4
(Assignee)

Comment 1

6 months ago
I'm happy to take on this one
(Assignee)

Comment 3

6 months ago
I don't have TRY permission. Soledad would you be able to kick that off please?
(Reporter)

Comment 4

6 months ago
Thank you, Dev!

I think it's simple enough that it doesn't even need a try run, since nothing was using this file anymore. I'll attempt landing the patch directly; the Phabricator page mentions it could build successfully.
Assignee: nobody → dev
Keywords: checkin-needed
@:Soledad, can you please accept the review from Phabricator, so can we land this change?
Flags: needinfo?(spenades)
(Reporter)

Comment 6

6 months ago
Comment on attachment 9010670 [details]
Bug 1492510 - Deleting obsolete reference from eslintrc. r=spenades

Soledad Penades [:sole] [:spenades] has approved the revision.
Attachment #9010670 - Flags: review+
(Reporter)

Comment 7

6 months ago
Gah, sorry Cristian, I really thought I had r+'ed it! I did it now. Mondays...
Flags: needinfo?(spenades)

Comment 8

6 months ago
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f2994e9dcc30
Deleting obsolete reference from eslintrc. r=sole
Keywords: checkin-needed

Comment 9

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f2994e9dcc30
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.