Closed Bug 1492510 Opened 2 years ago Closed 2 years ago

Remove AppCacheUtils from .eslintrc

Categories

(DevTools :: General, enhancement, P4)

enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: sole, Assigned: dev)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

This file does not exist anymore in the code base. It was removed in Bug 1469824, but this rule was accidentally left behind.

To fix this bug, the line `"client/shared/AppCacheUtils.jsm",` needs to be removed:
https://dxr.mozilla.org/mozilla-central/source/devtools/.eslintrc.js#93
Keywords: good-first-bug
Priority: -- → P4
I'm happy to take on this one
I don't have TRY permission. Soledad would you be able to kick that off please?
Thank you, Dev!

I think it's simple enough that it doesn't even need a try run, since nothing was using this file anymore. I'll attempt landing the patch directly; the Phabricator page mentions it could build successfully.
Assignee: nobody → dev
Keywords: checkin-needed
@:Soledad, can you please accept the review from Phabricator, so can we land this change?
Flags: needinfo?(spenades)
Comment on attachment 9010670 [details]
Bug 1492510 - Deleting obsolete reference from eslintrc. r=spenades

Soledad Penades [:sole] [:spenades] has approved the revision.
Attachment #9010670 - Flags: review+
Gah, sorry Cristian, I really thought I had r+'ed it! I did it now. Mondays...
Flags: needinfo?(spenades)
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f2994e9dcc30
Deleting obsolete reference from eslintrc. r=sole
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f2994e9dcc30
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.