Code to updating subscriber values for current private bugs is throwing errors in the phabbugz log

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: dkl, Assigned: dkl)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

45 bytes, text/x-github-pull-request
Details | Review
(Assignee)

Description

7 months ago
{"Fields":{"msg":"Checking for username squatters","type":"USERS"},"Hostname":"ip-172-31-32-138","Logger":"STDERR","Pid":"8","Type":"Bugzilla.Extension.PhabBugz.Feed","Timestamp":1537374856000000000,"EnvVersion":2,"Severity":6}
{"Fields":{"msg":"Updating subscriber values for old private bugs","type":"USERS"},"Hostname":"ip-172-31-32-138","Logger":"STDERR","Pid":"8","Type":"Bugzilla.Extension.PhabBugz.Feed","Timestamp":1537374861000000000,"EnvVersion":2,"Severity":6}
{"Fields":{"msg":"Processing bug 1451702","type":"USERS"},"Hostname":"ip-172-31-32-138","Logger":"STDERR","Pid":"8","Type":"Bugzilla.Extension.PhabBugz.Feed","Timestamp":1537374861000000000,"EnvVersion":2,"Severity":6}
{"Fields":{"msg":"Processing revision D1292","type":"USERS"},"Hostname":"ip-172-31-32-138","Logger":"STDERR","Pid":"8","Type":"Bugzilla.Extension.PhabBugz.Feed","Timestamp":1537374861000000000,"EnvVersion":2,"Severity":6}
{"Fields":{"msg":"Revision 1292 updated","type":"USERS"},"Hostname":"ip-172-31-32-138","Logger":"STDERR","Pid":"8","Type":"Bugzilla.Extension.PhabBugz.Feed","Timestamp":1537374863000000000,"EnvVersion":2,"Severity":6}
Use of uninitialized value $revision_id in concatenation (.) or string at /app/extensions/PhabBugz/lib/Feed.pm line 739.
{"Fields":{"msg":"Processing revision D","type":"USERS"},"Hostname":"ip-172-31-32-138","Logger":"STDERR","Pid":"8","Type":"Bugzilla.Extension.PhabBugz.Feed","Timestamp":1537374863000000000,"EnvVersion":2,"Severity":6}
Use of uninitialized value $revision_id in int at /app/extensions/PhabBugz/lib/Feed.pm line 741.
{"Fields":{"msg":"Can't call method \"add_subscriber\" on an undefined value at /app/extensions/PhabBugz/lib/Feed.pm line 744.\n"},"Hostname":"ip-172-31-32-138","Logger":"STDERR","Pid":"8","Type":"Bugzilla.Extension.PhabBugz.Feed","Timestamp":1537374863000000000,"EnvVersion":2,"Severity":0}
(Assignee)

Updated

7 months ago
Summary: Code to check for username squatting is throwing errors in the phabbugz log → Code to updating subscriber values for current private bugs is throwing errors in the phabbugz log
(Assignee)

Comment 1

7 months ago
I was able to fix the phabricator attachments in BMO that had incorrect filenames by looking for the affected bugs using:

select bug_id, attach_id, mimetype, filename from attachments where mimetype = 'text/x-phabricator-request' and filename not regexp '^phabricator-D[[:digit:]]+-url.txt$' order by attach_id

There were only 8-10 affected by this and were most probably attached manually by the user. 

I am also patching the code to skip over attachments that are not recognized properly as to not stop phabbugz from working.

dkl
(Assignee)

Comment 2

7 months ago
Posted file GitHub Pull Request
(Assignee)

Comment 3

7 months ago
Merged to master.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.