1492511 - Code to updating subscriber values for current private bugs is throwing errors in the phabbugz log

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Phabricator Integration, defect)

Description

[David Lawrence [:dkl]]

{"Fields":{"msg":"Checking for username squatters","type":"USERS"},"Hostname":"ip-172-31-32-138","Logger":"STDERR","Pid":"8","Type":"Bugzilla.Extension.PhabBugz.Feed","Timestamp":1537374856000000000,"EnvVersion":2,"Severity":6}
{"Fields":{"msg":"Updating subscriber values for old private bugs","type":"USERS"},"Hostname":"ip-172-31-32-138","Logger":"STDERR","Pid":"8","Type":"Bugzilla.Extension.PhabBugz.Feed","Timestamp":1537374861000000000,"EnvVersion":2,"Severity":6}
{"Fields":{"msg":"Processing bug 1451702","type":"USERS"},"Hostname":"ip-172-31-32-138","Logger":"STDERR","Pid":"8","Type":"Bugzilla.Extension.PhabBugz.Feed","Timestamp":1537374861000000000,"EnvVersion":2,"Severity":6}
{"Fields":{"msg":"Processing revision D1292","type":"USERS"},"Hostname":"ip-172-31-32-138","Logger":"STDERR","Pid":"8","Type":"Bugzilla.Extension.PhabBugz.Feed","Timestamp":1537374861000000000,"EnvVersion":2,"Severity":6}
{"Fields":{"msg":"Revision 1292 updated","type":"USERS"},"Hostname":"ip-172-31-32-138","Logger":"STDERR","Pid":"8","Type":"Bugzilla.Extension.PhabBugz.Feed","Timestamp":1537374863000000000,"EnvVersion":2,"Severity":6}
Use of uninitialized value $revision_id in concatenation (.) or string at /app/extensions/PhabBugz/lib/Feed.pm line 739.
{"Fields":{"msg":"Processing revision D","type":"USERS"},"Hostname":"ip-172-31-32-138","Logger":"STDERR","Pid":"8","Type":"Bugzilla.Extension.PhabBugz.Feed","Timestamp":1537374863000000000,"EnvVersion":2,"Severity":6}
Use of uninitialized value $revision_id in int at /app/extensions/PhabBugz/lib/Feed.pm line 741.
{"Fields":{"msg":"Can't call method \"add_subscriber\" on an undefined value at /app/extensions/PhabBugz/lib/Feed.pm line 744.\n"},"Hostname":"ip-172-31-32-138","Logger":"STDERR","Pid":"8","Type":"Bugzilla.Extension.PhabBugz.Feed","Timestamp":1537374863000000000,"EnvVersion":2,"Severity":0}

Comment 1

[David Lawrence [:dkl]]

I was able to fix the phabricator attachments in BMO that had incorrect filenames by looking for the affected bugs using:

select bug_id, attach_id, mimetype, filename from attachments where mimetype = 'text/x-phabricator-request' and filename not regexp '^phabricator-D[[:digit:]]+-url.txt$' order by attach_id

There were only 8-10 affected by this and were most probably attached manually by the user. 

I am also patching the code to skip over attachments that are not recognized properly as to not stop phabbugz from working.

dkl

Comment 2

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request

Comment 3

[David Lawrence [:dkl]]

Merged to master.