Closed Bug 1492599 Opened Last year Closed Last year

[mozbuild] Add MachCommandCondition.is_firefox_or_android method

Categories

(Release Engineering :: General, enhancement)

enhancement
Not set

Tracking

(firefox64 fixed)

RESOLVED FIXED
Tracking Status
firefox64 --- fixed

People

(Reporter: bc, Assigned: bc)

References

Details

Attachments

(1 file)

There are a number of places where we test individually for firefox or android and re-implement functions to do so. We can consolidate.
ahal: Please add or redirect if I should have a different reviewer.
Assignee: nobody → bob
Status: NEW → ASSIGNED
Attachment #9010442 - Flags: review?(ahal)
Blocks: 1492601
Comment on attachment 9010442 [details] [diff] [review]
mozbuild.is_firefox_or_android.patch

Review of attachment 9010442 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm. I guess this should theoretically be reviewed by someone on the build team, but it's simple enough and more 'mach' related than 'build' related.
Attachment #9010442 - Flags: review?(ahal) → review+
Comment on attachment 9010442 [details] [diff] [review]
mozbuild.is_firefox_or_android.patch

:tomprince Care to look this over?
Attachment #9010442 - Flags: review?(mozilla)
Attachment #9010442 - Flags: review?(mozilla) → review?(core-build-config-reviews)
Attachment #9010442 - Flags: review?(core-build-config-reviews) → review+
Pushed by bclary@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ee87961e237
[mozbuild] Add MachCommandCondition.is_firefox_or_android method, r=ahal,froydnj.
https://hg.mozilla.org/mozilla-central/rev/1ee87961e237
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.