1492660 - feTurbulence fails to render with certain filter sizes when baseFrequency="0 <nonzero>"

Status: RESOLVED FIXED

(Core :: SVG, defect, P3)

Description

[Cameron McCormack (:heycam)]

Attachment: test

See attachment, which was distilled from https://twitter.com/chriscoyier/status/1042555713506013184.

If I remove the filter primitive margin attributes (the x/y/width/height) or change the viewBox to say "0 0 30 20" then the turbulence is rendered.

Using baseFrequency="0 3" seems to work just fine.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: test

Comment 2

[Cameron McCormack (:heycam)]

The problem is that with the particular viewBox="" and filter primitive size in the test, we end up with a negative x-offset for the first turbulence tile.  We normally correct negative offsets to a positive value with the EquivalentNonNegativeOffset call in SVGTurbulenceRenderer::Render, but that does not handle zero base frequency values correctly.

Comment 3

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=891671dc4e4edcdcf74ac1d0078039fc52930c4c

Comment 4

[Cameron McCormack (:heycam)]

Attachment: Bug 1492660 - Deal with negative turbulence tile offsets when base frequency is zero

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 9010511 [details]
Bug 1492660 - Deal with negative turbulence tile offsets when base frequency is zero

Markus Stange [:mstange] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e07781e939c6
Deal with negative turbulence tile offsets when base frequency is zero r=mstange

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/e07781e939c6