1492671 - Intermittent Test Verify browser/components/payments/test/browser/browser_card_edit.js | [JavaScript Error: "getScreenshot(https://example.com/browser/browser/components/payments/test/browser/blank_page.html) failed: TypeError: NetworkError when

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Treeherder Bug Filer]

Filed by: aciure [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=200287495&repo=autoland

https://queue.taskcluster.net/v1/task/V3Cah3HeQaeZmuQpr_xOaQ/runs/0/artifacts/public/logs/live_backing.log

15:50:07     INFO - TEST-PASS | browser/components/payments/test/browser/browser_card_edit.js | Expect dom.payments.defaults.saveCreditCard to default to false - 
15:50:07     INFO - Calling add_link from test_add_link
15:50:07     INFO - Buffered messages logged at 15:50:07
15:50:07     INFO - Console message: [JavaScript Error: "getScreenshot(https://example.com/browser/browser/components/payments/test/browser/blank_page.html) failed: TypeError: NetworkError when attempting to fetch resource." {file: "resource://activity-stream/lib/Screenshots.jsm" line: 45}]
15:50:07     INFO - getScreenshotForURL@resource://activity-stream/lib/Screenshots.jsm:45:7
15:50:07     INFO - async*maybeCacheScreenshot@resource://activity-stream/lib/Screenshots.jsm:98:32
15:50:07     INFO - async*_fetchScreenshot@resource://activity-stream/lib/TopSitesFeed.jsm:439:11
15:50:07     INFO - async*_fetchIcon@resource://activity-stream/lib/TopSitesFeed.jsm:427:11
15:50:07     INFO - async*getLinksWithDefaults@resource://activity-stream/lib/TopSitesFeed.jsm:329:11
15:50:07     INFO - async*refresh@resource://activity-stream/lib/TopSitesFeed.jsm:352:25
15:50:07     INFO - async*onAction@resource://activity-stream/lib/TopSitesFeed.jsm:652:9
15:50:07     INFO - _middleware/</<@resource://activity-stream/lib/Store.jsm:51:11
15:50:07     INFO - Store/this[method]@resource://activity-stream/lib/Store.jsm:29:54
15:50:07     INFO - init/this.intervalId<@resource://activity-stream/lib/SystemTickFeed.jsm:16:41
15:50:07     INFO - notify@resource://gre/modules/Timer.jsm:42:7
15:50:07     INFO - 
15:50:07     INFO - waitForMessageFromWidget: paymentDialogReady
15:50:07     INFO - Buffered messages finished
15:50:07     INFO - TEST-UNEXPECTED-FAIL | browser/components/payments/test/browser/browser_card_edit.js | [JavaScript Error: "getScreenshot(https://example.com/browser/browser/components/payments/test/browser/blank_page.html) failed: TypeError: NetworkError when attempting to fetch resource." {file: "resource://activity-stream/lib/Screenshots.jsm" line: 45}]
15:50:07     INFO - getScreenshotForURL@resource://activity-stream/lib/Screenshots.jsm:45:7
15:50:07     INFO - async*maybeCacheScreenshot@resource://activity-stream/lib/Screenshots.jsm:98:32
15:50:07     INFO - async*_fetchScreenshot@resource://activity-stream/lib/TopSitesFeed.jsm:439:11
15:50:07     INFO - async*_fetchIcon@resource://activity-stream/lib/TopSitesFeed.jsm:427:11
15:50:07     INFO - async*getLinksWithDefaults@resource://activity-stream/lib/TopSitesFeed.jsm:329:11
15:50:07     INFO - async*refresh@resource://activity-stream/lib/TopSitesFeed.jsm:352:25
15:50:07     INFO - async*onAction@resource://activity-stream/lib/TopSitesFeed.jsm:652:9
15:50:07     INFO - _middleware/</<@resource://activity-stream/lib/Store.jsm:51:11
15:50:07     INFO - Store/this[method]@resource://activity-stream/lib/Store.jsm:29:54
15:50:07     INFO - init/this.intervalId<@resource://activity-stream/lib/SystemTickFeed.jsm:16:41
15:50:07     INFO - notify@resource://gre/modules/Timer.jsm:42:7

Comment 1

[Intermittent Failures Robot]

15 failures in 538 pushes (0.028 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 4
* autoland: 4
* mozilla-central: 7

Platform breakdown:
* windows10-64: 3
* osx-10-10: 6
* windows10-64-msvc: 1
* windows7-32: 3
* windows7-32-msvc: 1
* macosx64-nightly: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1492671&startday=2018-09-21&endday=2018-09-21&tree=all

Comment 2

[Intermittent Failures Robot]

24 failures in 2902 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 8
* mozilla-inbound: 6
* mozilla-central: 10

Platform breakdown:
* windows10-64: 6
* windows10-64-msvc: 2
* osx-10-10: 10
* windows7-32-msvc: 2
* windows7-32: 3
* macosx64-nightly: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1492671&startday=2018-09-17&endday=2018-09-23&tree=all

Comment 3

[Intermittent Failures Robot]

33 failures in 2773 pushes (0.012 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 12
* mozilla-inbound: 7
* mozilla-central: 14

Platform breakdown:
* windows10-64: 7
* windows10-64-msvc: 3
* windows7-32: 6
* osx-10-10: 15
* windows7-32-msvc: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1492671&startday=2018-09-24&endday=2018-09-30&tree=all

Comment 4

[Andrei Oprea [:andreio]]

Screenshot issue can be avoided by setting `browser.pagethumbnails.capturing_disabled=true` in browser.ini to skip screenshots.
But after applying this change tests fail will a bookmarks API issue, I'm not familiar with this and I don't think it's Activity Stream related. 
My guess would be bug 1426245 might have something to do with this.

FAIL [JavaScript Error: "BookmarkingUI failed adding a bookmarks observer: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.addObserver]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrome://browser/content/browser-places.js :: BUI_updateStarState/< :: line 1452"  data: no]" {file: "chrome://browser/content/browser-places.js" line: 1457}]
BUI_updateStarState/<@chrome://browser/content/browser-places.js:1457:14
promise callback*BUI_updateStarState@chrome://browser/content/browser-places.js:1433:8
BUI_onLocationChange@chrome://browser/content/browser-places.js:1419:5
onLocationChange@chrome://browser/content/browser.js:4921:7
callListeners@chrome://browser/content/tabbrowser.js:693:18
_callProgressListeners@chrome://browser/content/tabbrowser.js:706:7
_callProgressListeners@chrome://browser/content/tabbrowser.js:4733:12
onLocationChange@chrome://browser/content/tabbrowser.js:5097:7
_callProgressListeners@resource://gre/modules/RemoteWebProgress.jsm:153:11
receiveMessage@resource://gre/modules/RemoteWebProgress.jsm:240:7
MessageListener.receiveMessage*swapBrowser@resource://gre/modules/RemoteWebProgress.jsm:88:5
RemoteWebProgressManager@resource://gre/modules/RemoteWebProgress.jsm:71:3
construct@chrome://global/content/bindings/browser.xml:1015:46
browser_XBL_Constructor@chrome://global/content/bindings/browser.xml:979:9
_insertBrowser@chrome://browser/content/tabbrowser.js:2056:7
addTab@chrome://browser/content/tabbrowser.js:2466:9
addTab@resource://testing-common/BrowserTestUtils.jsm:1769:12
openNewForegroundTab/promises<@resource://testing-common/BrowserTestUtils.jsm:203:44
switchTab@resource://testing-common/BrowserTestUtils.jsm:292:7
openNewForegroundTab@resource://testing-common/BrowserTestUtils.jsm:198:9
withNewTab@resource://testing-common/BrowserTestUtils.jsm:109:21
async*test_private_card_adding@chrome://mochitests/content/browser/browser/components/payments/test/browser/browser_card_edit.js:630:9
Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1093:34
async*Tester_execTest@chrome://mochikit/content/browser-test.js:1084:16
nextTest/<@chrome://mochikit/content/browser-test.js:986:9
SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59

Comment 5

[Matthew N. [:MattN]]

So are you thinking the errors are expected in the test then?

(In reply to Andrei Oprea [:andreio] from comment #4)
> Screenshot issue can be avoided by setting
> `browser.pagethumbnails.capturing_disabled=true` in browser.ini to skip
> screenshots.
> But after applying this change tests fail will a bookmarks API issue, I'm
> not familiar with this and I don't think it's Activity Stream related. 
> My guess would be bug 1426245 might have something to do with this.

Did you see this on try or locally? I don't see that locally.

Comment 6

[Intermittent Failures Robot]

1 failures in 2740 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-central: 1

Platform breakdown:
* linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1492671&startday=2018-10-08&endday=2018-10-14&tree=all

Comment 7

[Andrei Oprea [:andreio]]

Attachment: Bug 1492671 - Disable screenshot capturing for triggering network requests in payments mochitests

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a4b8a6a0881
Disable screenshot capturing for triggering network requests in payments mochitests r=MattN

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/3a4b8a6a0881