1492694 - invalid filter primitive in="" attributes should be treated as if they weren't specified

Status: RESOLVED FIXED

(Core :: SVG, enhancement, P3)

Description

[Cameron McCormack (:heycam)]

We currently make the entire filter invalid in this case.

Comment 1

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=710deb259784fb530127df28be5b747935b182e9

Comment 2

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4285c2e1b74158f3041c430192e7d247d7e9396f

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Bug 1492694 - Treat invalid in="" attributes as if they weren't specified

Comment 4

[Robert Longson [:longsonr]]

Is this specified? What other UAs work this way?

Comment 5

[Cameron McCormack (:heycam)]

Yes, it's specified in https://www.w3.org/TR/filter-effects-1/#element-attrdef-filter-primitive-in:

  References to non-existent results will be treated as if no result was specified.

Chrome behaves this way at least.

Comment 6

[Robert Longson [:longsonr]]

Comment on attachment 9010517 [details]
Bug 1492694 - Treat invalid in="" attributes as if they weren't specified

Robert Longson [:longsonr] has approved the revision.

Comment 7

[Cameron McCormack (:heycam)]

Safari matches current Firefox behavior (those two tests show red rects).

Edge matches current Firefox behavior for the first subtest, but fails in a different way (it shows a green/blue rect) in the second subtest.

Comment 8

[Cameron McCormack (:heycam)]

Anyway, although Chrome is the only one matching the spec right now, the spec requirement seems reasonable, and hopefully the tests will help nudge the others to change.

Comment 9

[Cameron McCormack (:heycam)]

(In reply to Cameron McCormack (:heycam) from comment #7)
> Edge matches current Firefox behavior for the first subtest, but fails in a
> different way (it shows a green/blue rect) in the second subtest.

My mistake, that was a bug in the second test. :-)  Edge passes this test with the correction.

Comment 10

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3dc50a089cd4972f4f771cf6b93afd4cd5e27879

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fa839cdb888
Treat invalid in="" attributes as if they weren't specified r=longsonr

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13107 for changes under testing/web-platform/tests

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13107
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/fsp7UtvUTiG8AvjwTLnwKw)
* continuous-integration/travis-ci/pr (https://travis-ci.org/web-platform-tests/wpt/builds/430954817?utm_source=github_status&utm_medium=notification)

Comment 14

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/4fa839cdb888

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/06523f0124bb
Followup to avoid some filter fuzziness. r=me

Comment 16

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/06523f0124bb