Fix a cookie policy range check in CookieServiceChild

RESOLVED FIXED in Firefox 63

Status

()

defect
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: baku, Assigned: baku)

Tracking

({regression})

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox62 unaffected, firefox63 fixed, firefox64 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

8 months ago
https://searchfox.org/mozilla-central/rev/94e37e71ffbfd39e6ad73ebcda5d77cce8d341ae/netwerk/cookie/CookieServiceChild.cpp#304-307

This check is wrong because it doesn't consider the new BEHAVIOR_REJECT_TRACKER policy.
Assignee

Comment 1

8 months ago
Posted patch fix.patchSplinter Review
Attachment #9010561 - Flags: review?(ehsan)

Comment 2

8 months ago
Comment on attachment 9010561 [details] [diff] [review]
fix.patch

Review of attachment 9010561 [details] [diff] [review]:
-----------------------------------------------------------------

Please request uplift as well.
Attachment #9010561 - Flags: review?(ehsan) → review+

Updated

8 months ago
Blocks: 1480780
Keywords: regression

Comment 3

8 months ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d99742ecb5f
Fix a cookie policy range check in CookieServiceChild, r=ehsan
Assignee

Comment 4

8 months ago
Comment on attachment 9010561 [details] [diff] [review]
fix.patch

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1480780
[User impact if declined]: Wrong cookie policy can be applied when retrieving/setting cookies. In particular the new cookie policy 4 is ignored.
[Is this code covered by automated tests?]: n/a
[Has the fix been verified in Nightly?]: n/a
[Needs manual test from QE? If yes, steps to reproduce]: n/a 
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: none
[Why is the change risky/not risky?]: it's just a range check.
[String changes made/needed]: none
Attachment #9010561 - Flags: approval-mozilla-beta?

Comment 5

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5d99742ecb5f
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment on attachment 9010561 [details] [diff] [review]
fix.patch

Minimal patch fixing a well defined bug, uplift approved for 63 beta 9, thanks.
Attachment #9010561 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.