1492769 - Fix a cookie policy range check in CookieServiceChild

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Andrea Marchesini [:baku]]

https://searchfox.org/mozilla-central/rev/94e37e71ffbfd39e6ad73ebcda5d77cce8d341ae/netwerk/cookie/CookieServiceChild.cpp#304-307

This check is wrong because it doesn't consider the new BEHAVIOR_REJECT_TRACKER policy.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: fix.patch

Comment 2

[(no longer active)]

Comment on attachment 9010561 [details] [diff] [review]
fix.patch

Review of attachment 9010561 [details] [diff] [review]:
-----------------------------------------------------------------

Please request uplift as well.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d99742ecb5f
Fix a cookie policy range check in CookieServiceChild, r=ehsan

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 9010561 [details] [diff] [review]
fix.patch

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1480780
[User impact if declined]: Wrong cookie policy can be applied when retrieving/setting cookies. In particular the new cookie policy 4 is ignored.
[Is this code covered by automated tests?]: n/a
[Has the fix been verified in Nightly?]: n/a
[Needs manual test from QE? If yes, steps to reproduce]: n/a 
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: none
[Why is the change risky/not risky?]: it's just a range check.
[String changes made/needed]: none

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/5d99742ecb5f

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9010561 [details] [diff] [review]
fix.patch

Minimal patch fixing a well defined bug, uplift approved for 63 beta 9, thanks.

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b0837e4c127a