1492826 - Better document target.attach and the various attach requests.

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

Bug 1485676 highlighted that we use "attach" in a couple of places, but these methods are rarely well documented.
So we should try to better document them:
  TabTarget.attach
  DebuggerClient.attachTarget
  DebuggerClient.attachConsole

It may then help simplify the overall "attach" story that is quite messy between what we do in TabTarget.attach and what we do in the toolbox.open:
https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox.js#452-464

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1492826 - Better document TabTarget.attach as well as DebuggerClient.attachTarget and attachConsole. r=jdescottes

Depends On D6162

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 9010612 [details]
Bug 1492826 - Better document TabTarget.attach as well as DebuggerClient.attachTarget and attachConsole. r=jdescottes

Julian Descottes [:jdescottes][:julian] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0aeab777cf0
Better document TabTarget.attach as well as DebuggerClient.attachTarget and attachConsole. r=jdescottes

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/f0aeab777cf0