1492827 - The console should not request FileActivity if it is not using these events.

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Description

[Alexandre Poirot [:ochameau]]

The console frontend requests the server to send FileActivity events event:
https://searchfox.org/mozilla-central/rev/94e37e71ffbfd39e6ad73ebcda5d77cce8d341ae/devtools/client/webconsole/webconsole-connection-proxy.js#176

Whereas it is not using these events:
https://searchfox.org/mozilla-central/rev/94e37e71ffbfd39e6ad73ebcda5d77cce8d341ae/devtools/client/webconsole/webconsole-connection-proxy.js#371

We should at least stop requesting for these events in attachConsole, and may be remove this "TODO" code and the one similar for reflow events. (ie. the calls to client.addListener)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1492827 - Remove unused listeners and handlers from webconsole-connection-proxy; r=ochameau.

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 9012559 [details]
Bug 1492827 - Remove unused listeners and handlers from webconsole-connection-proxy; r=ochameau.

Alexandre Poirot [:ochameau] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbe6ee092645
Remove unused listeners and handlers from webconsole-connection-proxy; r=ochameau.

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/fbe6ee092645