1492829 - [checks] Projects show up as incomplete because of strings with warnings

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P2)

Description

[Francesco Lodolo [:flod]]

Consider for example Italian: 10793 strings, 3 warnings, 10790 strings.
https://pontoon.mozilla.org/it/firefox/

Firefox is showing up as not completely translated (99%), while it's fully translated, even if there are 3 warnings.

Warnings shouldn't count towards completion.

Comment 1

[Matjaz Horvat [:mathjazz]]

ATM, Each string can be in one of the 5 states:
- Translated
- Fuzzy
- (Strings with) Warnings
- (Strings with) Errors
- Missing

Project completion is calculated as "The number of Translated strings divided by the number of All strings". Since states are mutually exclusive, Strings with warnings are excluded from Translated.

--

There are two ways to fix the project completion calculation:

1. Change the calculation to "The number of Translated strings and Strings with warnings divided by the number of All strings".

2. Get rid of the "(Strings with) Warnings" state completely and treat Warnings similarly to Unreviewed. That has several consequences, including:
- In string list, Strings with Warnings will have the green icon instead of orange.
- The Warnings filter should be moved further down towards Unreviewed. The rectangle icon should be changed.
- The Translated filter should also catch strings with Warnings.
- Warnings should be excluded from Circular progress chart and legend (they only represent states).
- We'd need to change the way we calculate stats and re-calculate them.

:flod, which option would you prefer?

Comment 2

[Francesco Lodolo [:flod]]

(In reply to Matjaz Horvat [:mathjazz] from comment #1)
> 1. Change the calculation to "The number of Translated strings and Strings
> with warnings divided by the number of All strings".

I think this approach is preferable.

The annoying part of this bug is that Pontoon keeps yelling at me "this project needs work", when it doesn't. Until that's possible (i.e. I'm able to mark a warning as false positive), fixing the calculation for completion would be enough.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1085

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/cfe2cec9cce259528849aba0925ed1c66e25cb67
Fix bug 1492829: Include warnings in completion percent (#1085)

Also: Rename approved_percent to completion_percent.