1492958 - [css-ui] Unship -moz/webkit-user-select values not supported by other UAs / spec

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Mats Palmgren (inactive)]

The css-ui spec currently has these values:
 	auto | text | none | contain | all 
https://drafts.csswg.org/css-ui-4/#propdef-user-select

Chrome (v70) supports those, except 'contain' (which I'm guessing
is a fairly recent addition to the spec).

Gecko supports a lot more values (element/elements/tri-state/toggle/...)
which we also expose on -webkit-user-select due to it being an
alias for -moz-user-select.  We should remove these extra values
if possible, or at least make them internal values only available
to UA/Chrome sheets in case we need them.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Yeah, let's do this... It's really confusing to support the -webkit- prefixed version and not the unprefixed one.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1492958 - Move user-select outside of mako.

This is the first step to unprefix user-select.

This has no behavior change, it's just a nicer way to do the same thing which
allows us to unship individual values more easily using parse(condition).

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1492958 - Remove unimplemented values of the user-select property.

Can't believe we literally had no code to handle them.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1492958 - Remove user-select: -moz-all.

It's an attempt of an alias to `all`, except it doesn't get handled in all
places.

Seems unused both in comm-central and mozilla-central, and all external usage I
could find is followed by -webkit-user-select: all.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1492958 - Allow user-select: -moz-text on user-agent stylesheets only.

It's only used in contenteditable.css, and same usage in comm-central. That
sheet is loaded as a ua sheet so let's restrict it to that. No relevant
external usage either. This value was introduced in bug 1181130.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/edc955448df6
Move user-select outside of mako. r=xidorn
https://hg.mozilla.org/integration/mozilla-inbound/rev/59cf251c1a59
Remove unimplemented values of the user-select property. r=mats
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e643bc2e17b
Remove user-select: -moz-all. r=mats
https://hg.mozilla.org/integration/mozilla-inbound/rev/e59edfbbd327
Allow user-select: -moz-text on user-agent stylesheets only. r=mats
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7c8793ee054
Update the devtools property database.

Comment 7

[Eliza Balazs [:ebalazs_]]

Backed out 5 changesets (Bug 1492958) for bc failures in browser/base/content/test/static/browser_parsable_css.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&selectedJob=211181552&revision=d7c8793ee054c4b37256fedb88e00b4cfb193ef2

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=211181552&repo=mozilla-inbound&lineNumber=2795

Backout push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=442a3c0bcd48daaff9eb76cc8dae160c57dcbb3a

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43dbbb0cce0d
Move user-select outside of mako. r=xidorn
https://hg.mozilla.org/integration/mozilla-inbound/rev/df2dae63f7fa
Remove unimplemented values of the user-select property. r=mats
https://hg.mozilla.org/integration/mozilla-inbound/rev/00aa04d26dc4
Remove user-select: -moz-all. r=mats
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f3b7d15aa3c
Allow user-select: -moz-text on user-agent stylesheets only. r=mats
https://hg.mozilla.org/integration/mozilla-inbound/rev/e631224b7fa9
Update the devtools property database.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Sigh, that test always gets me every time I make something UA-only... Added an exception.

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/43dbbb0cce0d
https://hg.mozilla.org/mozilla-central/rev/df2dae63f7fa
https://hg.mozilla.org/mozilla-central/rev/00aa04d26dc4
https://hg.mozilla.org/mozilla-central/rev/3f3b7d15aa3c
https://hg.mozilla.org/mozilla-central/rev/e631224b7fa9

Comment 11

[Binyamin]

Are you completely removing "user-select" (https://drafts.csswg.org/css-ui-4/#propdef-user-select) support?
Firefox Nightly still doesn't support unprefixed "user-select".

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Wait what? No, we're not.

We're removing proprietary values and values that didn't have any implementation but that parse, like '-moz-user-select: element'.

Plan is to eventually unprefix in bug 1492739. That has a patch but I need to get around fixing bug 1506547 before.

Comment 13

[Chris Mills [:cmills]]

So, I think I've documented this sufficiently. I've added a note to the Fx 65 rel notes:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/65#CSS

I also checked the user-select page to make sure we don't mention the proprietary Moz-only values.

Let me know if you think this needs anything else. Thanks!

Comment 14

[Kohei Yoshino]

Posted site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/non-standard-moz-user-select-values-have-been-removed/