1493027 - Access permissions without creating MediaManager

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Alastor Wu [:alwu]]

One possible scenario is that you're sharing screen with other people and also receive other people's live video stream.

In this case, we should allow the autoplay.

Comment 1

[Alastor Wu [:alwu]]

I found that MediaManager::IsActivelyCapturingOrHasAPermission() would return true when user grants 'screen' permission, so we have handled this case.

However, we didn't handle the edge-case which was mentioned in bug1182329 comment49, and also didn't have any test cases yet.

So I will fix that edge-case and add test case in this bug.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1493027 - part1 : access permissions without creating MediaManager.

If a site had been granted persistent permissions, but hasn't accessed navigator.mediaDevices yet.
Then, we can't read the permission because MediaManager hasn't be created yet.

We should read these permissions without loading MediaManager.

In addition, I noticed that even user only requests 'screen' permission, we would also add the 'camera'
and 'microphone' permission in the nsIPermissionManager. That makes us no way to print the log to distinguish
what actually permission user granted.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1493027 - part2 : add test.

Comment 4

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c3378075b1c5637290c8d5e24eb73f5fd8a341a

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 9011128 [details]
Bug 1493027 - part1 : access permissions without creating MediaManager.

Chris Pearce (:cpearce) has approved the revision.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 9011129 [details]
Bug 1493027 - part2 : add test.

Chris Pearce (:cpearce) has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd4c5546dfa3
part1 : access permissions without creating MediaManager. r=cpearce

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eaccb6c8b0d0
part2 : add test. r=cpearce

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/fd4c5546dfa3
https://hg.mozilla.org/mozilla-central/rev/eaccb6c8b0d0