Closed Bug 1493043 Opened Last year Closed Last year

Change function arguments from nsIFrame& to nsIFrame* in RestyleManager

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

Details

Attachments

(1 file)

While debugging ExpectedOwnerForChild(), I notice its argument is nsIFrame&, which somewhat deviates from the convention used in layout. It also make it harder to use gdb/lldb debug command like "ftl" [1].

I'd like to change those nsIFrame& arguments in RestyleManager to nsIFrame*.

[1] https://searchfox.org/mozilla-central/rev/0b8ed772d24605d7cb44c1af6d59e4ca023bd5f5/third_party/python/lldbutils/README.txt#32
Comment on attachment 9010821 [details]
Bug 1493043 - Change function arguments in RestyleManager from nsIFrame& to nsIFrame*

Emilio Cobos Álvarez (:emilio) has approved the revision.
Attachment #9010821 - Flags: review+
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b84d8d3b922b
Change function arguments in RestyleManager from nsIFrame& to nsIFrame* r=emilio
https://hg.mozilla.org/mozilla-central/rev/b84d8d3b922b
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.