Closed Bug 1493049 Opened 7 years ago Closed 7 years ago

Stop using nsSVGPaintingProperty for observing SVG "template" elements

Categories

(Core :: SVG, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

No description provided.
Using nsSVGPaintingProperty to observe SVG "template" elements means that we unnecessarily call InvalidateFrameSubtree(), and unnecessarily call InvalidateRenderingObservers instead of just calling InvalidateDirectRenderingObservers. Besides that it's confusing to anyone trying to understand the code why href-to-template is a "painting" property. Creating a new type solves all these issues.
Comment on attachment 9010823 [details] Bug 1493049 - Stop using nsSVGPaintingProperty for observing SVG "template" elements. r?longsonr Robert Longson [:longsonr] has approved the revision.
Attachment #9010823 - Flags: review+
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/07823cdfe1c9 Stop using nsSVGPaintingProperty for observing SVG "template" elements. r=longsonr
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: