Remove obsolete comment about webidl callback parameter being nulled before use

RESOLVED FIXED in Firefox 65

Status

()

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Importance:
P3
normal
Status:
RESOLVED FIXED
Opened:
10 months ago
Updated:
4 months ago

People

(Reporter: karlt, Assigned: karlt)

Tracking

Version:
Trunk
Target:
mozilla65
Points:
---

Firefox Tracking Flags

(firefox64 wontfix, firefox65 fixed)

Details

Attachments

(1 attachment)

Bug 1493073 Remove obsolete comment about webidl callback parameter being nulled before use r?kmag
46 bytes, text/x-phabricator-request
Details | Review 
No description provided.
CustomElementRegistryBinding uses RootedCallback and so the constructor cannot
be nulled.

The comment was added to warn about an unrooted callback argument
from nsDocument::RegisterElement(), a caller that no longer exists.

https://bugzilla.mozilla.org/show_bug.cgi?id=1369533#c25
https://hg.mozilla.org/mozilla-central/rev/16d0cd656b05#l6.298
Pushed by ktomlinson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe93d4aaced2
Remove obsolete comment about webidl callback parameter being nulled before use r=kmag
https://hg.mozilla.org/mozilla-central/rev/fe93d4aaced2
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.