Closed Bug 1493148 Opened 2 years ago Closed 2 years ago

Perma multiple failures in e.g. extensions/cookie/test/unit/test_cookies_thirdparty.js when Gecko 64 merges to Beta on 2018-10-15

Categories

(Firefox :: Protections UI, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 64
Tracking Status
geckoview62 --- unaffected
firefox-esr60 --- unaffected
firefox62 --- unaffected
firefox63 --- unaffected
firefox64 --- verified

People

(Reporter: ebalazs_, Assigned: ehsan)

References

Details

(Keywords: regression)

Assignee: nobody → ehsan
Priority: -- → P1
I can reproduce.
Flags: needinfo?(ehsan)
Well, this is embarrassing!

Now that I look at this again, it's so obvious that it's a bit funny!  Part 3 of bug 1491061 was actually only necessary before part 4, since in part 4 I updated the Gecko checks to match the default values of the content blocking preferences, whatever they may be.  So with part 4, part 3 actually makes all of the tests that it touches now be wrong, since the prefs that we're setting in those tests will be inconsistent e.g. on beta!  This test failure, plus tons of others in the push in comment 0 is a result of that.

The fix is simple: back out part 3 of bug 1491061.
https://hg.mozilla.org/mozilla-central/rev/13c9130747de
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
There is a failure missing from the first comment: 

https://treeherder.mozilla.org/logviewer.html#?job_id=200985482&repo=try&lineNumber=4223

13:29:08     INFO - TEST-START | toolkit/components/antitracking/test/browser/browser_blockingCookies.js
13:29:08     INFO - TEST-INFO | started process screenshot
13:29:08     INFO - TEST-INFO | screenshot: exit 0
13:29:08     INFO - Buffered messages logged at 13:29:08
13:29:08     INFO - Entering test bound 
13:29:08     INFO - Starting blocking cookieBehavior (4) and blocking contentBlocking and  contentBlocking UI and  contentBlocking third-party cookies UI without allow list test Set/Get Cookies running in a normal window  with iframe sandbox set to null
13:29:08     INFO - Creating a new tab
13:29:08     INFO - Creating a 3rd party content
13:29:08     INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.net/browser/toolkit/components/antitracking/test/browser/page.html" line: 0}]
13:29:08     INFO - Sending code to the 3rd party content
13:29:08     INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_blockingCookies.js | No cookies for me - true == true - 
13:29:08     INFO - Buffered messages finished
13:29:08     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/browser/browser_blockingCookies.js | No cookies for me - false == true - 
13:29:08     INFO - Stack trace:
13:29:08     INFO - resource://testing-common/content-task.js line 59 > eval:msg:22
13:29:08     INFO - Not taking screenshot here: see the one that was previously logged
13:29:08     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/browser/browser_blockingCookies.js | We should not have cookies - false == true - 
13:29:08     INFO - Stack trace:
13:29:08     INFO - resource://testing-common/content-task.js line 59 > eval:msg:22
13:29:08     INFO - Not taking screenshot here: see the one that was previously logged
13:29:08     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/browser/browser_blockingCookies.js | We should not have cookies - false == true - 
13:29:08     INFO - Stack trace:
13:29:08     INFO - resource://testing-common/content-task.js line 59 > eval:msg:22
13:29:08     INFO - Not taking screenshot here: see the one that was previously logged
13:29:08     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/browser/browser_blockingCookies.js | Still no cookies for me - false == true - 
13:29:08     INFO - Stack trace:
13:29:08     INFO - resource://testing-common/content-task.js line 59 > eval:msg:22
13:29:08     INFO - Not taking screenshot here: see the one that was previously logged
13:29:08     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/browser/browser_blockingCookies.js | Checking cookie blocking notifications - Got false, expected true
13:29:08     INFO - Stack trace:
13:29:08     INFO - chrome://mochikit/content/browser-test.js:test_is:1304
13:29:08     INFO - chrome://mochitests/content/browser/toolkit/components/antitracking/test/browser/head.js:_createTask/<:519
13:29:08     INFO - Removing the tab
13:29:08     INFO - Leaving test bound 
13:29:08     INFO - Entering test bound 
13:29:08     INFO - Cleaning up.
13:29:08     INFO - Leaving test bound 
13:29:08     INFO - Entering test bound 
13:29:08     INFO - Starting non-blocking cookieBehavior (0) and blocking contentBlocking and  contentBlocking UI and  contentBlocking third-party cookies UI without allow list test Set/Get Cookies running in a normal window  with iframe sandbox set to null
13:29:09     INFO - GECKO(1700) | JavaScript error: resource://gre/modules/WebProgressChild.jsm, line 58: TypeError: this.mm.content is null; can't access its "document" property
13:29:09     INFO - Console message: [JavaScript Error: "TypeError: this.mm.content is null; can't access its "document" property" {file: "resource://gre/modules/WebProgressChild.jsm" line: 58}]
13:29:09     INFO - Creating a new tab
13:29:09     INFO - Creating a 3rd party content
13:29:09     INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.net/browser/toolkit/components/antitracking/test/browser/page.html" line: 0}]
13:29:09     INFO - Sending code to the 3rd party content
13:29:09     INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_blockingCookies.js | No cookies for me - true == true - 
13:29:09     INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_blockingCookies.js | We should not have cookies - true == true - 
13:29:09     INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_blockingCookies.js | Some cookies for me - true == true - 
13:29:09     INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_blockingCookies.js | Some cookies for me - true == true - 
13:29:09     INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_blockingCookies.js | We should have cookies - true == true - 
13:29:09     INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_blockingCookies.js | Some Cookies for me - true == true - 
13:29:09     INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_blockingCookies.js | Checking cookie blocking notifications - 
13:29:09     INFO - Removing the tab

Ehsan: this is still occurring on today's beta simulations which means it's not fixed. Can you please take a look?
Status: RESOLVED → REOPENED
Flags: needinfo?(ehsan)
Resolution: FIXED → ---
Target Milestone: Firefox 64 → ---
Note: the failures mentioned by Eliza in the first comment no longer appear, just the ones in Comment 5.
I would always appreciate filing new bugs for remaining issues instead of commenting on old bugs with patches landed.  Thanks!
Flags: needinfo?(ehsan)
Filed bug 1493682 for comment 5.
Ehsan: Noted and thanks for looking into this.
According to Comment 9, a new bug was created for the remaining issue so I am closing this as Resolved Fixed.
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Depends on: 1494145
QA Contact: francois
You need to log in before you can comment on or make changes to this bug.