Closed Bug 1493160 Opened 8 years ago Closed 8 years ago

Can't change to blocking and accept revision at the same time

Categories

(Conduit :: Phabricator, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: standard8, Unassigned)

Details

I just finished the review on a patch, and wanted to request additional review from someone else. So at the comment section I: - Selected the action "Accept this revision" - Selected the action "Change Reviewers" -- I changed myself from non-blocking to blocking -- I added the new reviewer as blocking - I added a comment & submitted. Expected Results => Both myself and the new reviewer to be marked as blocking, but with my review accepted. Actual Results => Both myself and the new reviewer were marked as blocking. However, it still said my review was needed. I'm pretty sure when I've done this in the past via the Edit Revision, it hasn't forgotten the fact I've accepted the revision already. For reference the revision was https://phabricator.services.mozilla.com/D5831
So this is a bit confusing, but I believe it's working as designed. From the revision timeline: Standard8 accepted this revision. Standard8 added a reviewer: mak. Standard8 added 1 blocking reviewer(s): Standard8. Standard8 added a subscriber: mak. Comment Actions Thanks for the update. This is looking good. @mak Can you take a look at the changes here as well please? I'd like to make sure I haven't missed anything with the history APIs. Standard8 accepted this revision. It looks like the actions are performed in the order that they are selected from the dropdown. So you accepted the revision, but when you then added yourself as a blocking reviewer, it re-added you since you hadn't previously given a review as a blocking reviewer. I just confirmed this by performing those two actions separately, which gave the same results. So in the future if you want to make yourself blocking and accept at the same time, just change the reviewers first, then accept it (I verified that this will indeed do both).
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.