1493274 - In-context localization is broken for Fundraising and Thimble

Status: RESOLVED WORKSFORME

(Webtools Graveyard :: Pontoon, defect, P3)

Description

[Théo Chevalier]

Projects with in-context localization can’t be opened: Pontoon is stuck on the loading screen.

I went ahead and disabled in-context localization from Fundraising and Thimble as a stop-gap solution, so that there’s no urgency in fixing this and folks can still localize.

Comment 1

[Matjaz Horvat [:mathjazz]]

Seems to be working fine with Pontoon Intro:
https://pontoon.mozilla.org/sl/pontoon-intro/messages.properties/?string=33058

Maybe Fundraising and Thimble websites broke in-context compatibility?

Comment 2

[Théo Chevalier]

Hum, it could be if that’s related to the infra (they are both Node.js apps running on Heroku) but probably not from a code standpoint: the last commit for both projects comes from Pontoon:

https://github.com/mozilla/donate.mozilla.org/commits/master
https://github.com/mozilla/thimble.mozilla.org/commits/master

However Pontoon intro works for me as well

Comment 3

[Théo Chevalier]

Checked with our devops, he’s not aware of recent changes for those staging servers

Comment 4

[Matjaz Horvat [:mathjazz]]

Pontoon sadly requires jQuery for in-context localization to work, at least until bug 1303066 is fixed.

So if the page doesn't use jQuery, Pontoon tries to inject it in the page. But it can't, because it's blocked by the CSP (or something similar) of the website:
https://developer.mozilla.org/en-US/docs/Mozilla/Implementing_Pontoon_in_a_Mozilla_website#B._(optional)_Enable_in-page_localization_of_your_web_project

As per bug the overlooked bug 1488075, this has been broken for a while. We should check with the website devs if they changed CSP or other security settings recently.

Comment 6

[Théo Chevalier]

Weird, it seems it didn’t break at the same time for everybody, because there’s been lots of commits from Pontoon on https://github.com/mozilla/donate.mozilla.org/commits/master between Sept 2nd (when bug 148075 was filed) and when it broke for me and I disabled in-context l10n. I wonder if some cache helped.

It seems CSPs are managed here: https://github.com/mozilla/donate.mozilla.org/blob/master/server/services.js#L57-L70
While there’s been no change to this file, it could be the Node package used got an update and broke something.

Comment 7

[Matjaz Horvat [:mathjazz]]

(In reply to Théo Chevalier [:tchevalier] (please use NI) from comment #6)
> Weird, it seems it didn’t break at the same time for everybody, because
> there’s been lots of commits from Pontoon on
> https://github.com/mozilla/donate.mozilla.org/commits/master between Sept
> 2nd (when bug 148075 was filed) and when it broke for me and I disabled
> in-context l10n. I wonder if some cache helped.

I suspect it did break for everybody, but the in-context localization is disable when you translate "All Resources".

Comment 8

[Théo Chevalier]

(In reply to Matjaz Horvat [:mathjazz] from comment #7)
> (In reply to Théo Chevalier [:tchevalier] (please use NI) from comment #6)
> > Weird, it seems it didn’t break at the same time for everybody, because
> > there’s been lots of commits from Pontoon on
> > https://github.com/mozilla/donate.mozilla.org/commits/master between Sept
> > 2nd (when bug 148075 was filed) and when it broke for me and I disabled
> > in-context l10n. I wonder if some cache helped.
> 
> I suspect it did break for everybody, but the in-context localization is
> disable when you translate "All Resources".

Ah, right, that would definitely explain why it took me so long to notice, I almost always use "All Resources"