1493375 - [wpt-sync] Sync PR 13156 - Revert "bindings: Implement timers with V8Function"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 13156 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13156
Details from upstream follow.

Frank Liberato <[e-mail]> wrote:
>  Revert "bindings: Implement timers with V8Function"
>  
>  This reverts commit 254369a5f6df06c2c6be067d14c2cb2a036ba173.
>  
>  Reason for revert: \<INSERT REASONING HERE>
>  
>  Original change's description:
>  > bindings: Implement timers with V8Function
>  > 
>  > This fixes bug 866610 by using the IDL infrastructure to properly enter
>  > the v8::Context before calling the registered callback.
>  > 
>  > Also ensure eager finalization of ScheduledAction in DOMTimer to
>  > prevent a memory leak. Added two more effective DCHECKs to confirm.
>  > 
>  > Bug: 866610
>  > Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1
>  > Reviewed-on: https://chromium-review.googlesource.com/1220486
>  > Reviewed-by: Nate Chapin \<[e-mail]>
>  > Reviewed-by: Yuki Shiino \<[e-mail]>
>  > Reviewed-by: Hitoshi Yoshida \<[e-mail]>
>  > Commit-Queue: Timothy Gu \<[e-mail]>
>  > Cr-Commit-Position: refs/heads/master@{#593108}
>  
>  TBR=[e-mail],[e-mail],[e-mail],[e-mail],[e-mail]
>  
>  Change-Id: Ifaccc3374466b851fc28b10c63ed1397bdae635e
>  No-Presubmit: true
>  No-Tree-Checks: true
>  No-Try: true
>  Bug: 866610
>  Reviewed-on: https://chromium-review.googlesource.com/1239216
>  Reviewed-by: Frank Liberato \<[e-mail]>
>  Commit-Queue: Frank Liberato \<[e-mail]>
>  Cr-Commit-Position: refs/heads/master@{#593260}
>

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 13156 applied with additional changes from upstream: 4eaebdf70cbbbac6b95d757c424a879c1f980dac

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=0cd4d1ca9f43e97e2424ce74ef4445a65d452824

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b19db2da4eb
[wpt PR 13156] - Revert "bindings: Implement timers with V8Function", a=testonly

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Result changes from PR not available.

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/6b19db2da4eb