Closed Bug 1493375 Opened Last year Closed Last year

[wpt-sync] Sync PR 13156 - Revert "bindings: Implement timers with V8Function"

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 13156 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13156
Details from upstream follow.

Frank Liberato <liberato@chromium.org> wrote:
>  Revert "bindings: Implement timers with V8Function"
>  
>  This reverts commit 254369a5f6df06c2c6be067d14c2cb2a036ba173.
>  
>  Reason for revert: \<INSERT REASONING HERE>
>  
>  Original change's description:
>  > bindings: Implement timers with V8Function
>  > 
>  > This fixes bug 866610 by using the IDL infrastructure to properly enter
>  > the v8::Context before calling the registered callback.
>  > 
>  > Also ensure eager finalization of ScheduledAction in DOMTimer to
>  > prevent a memory leak. Added two more effective DCHECKs to confirm.
>  > 
>  > Bug: 866610
>  > Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1
>  > Reviewed-on: https://chromium-review.googlesource.com/1220486
>  > Reviewed-by: Nate Chapin \<japhet@chromium.org>
>  > Reviewed-by: Yuki Shiino \<yukishiino@chromium.org>
>  > Reviewed-by: Hitoshi Yoshida \<peria@chromium.org>
>  > Commit-Queue: Timothy Gu \<timothygu@chromium.org>
>  > Cr-Commit-Position: refs/heads/master@{#593108}
>  
>  TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,japhet@chromium.org,timothygu@chromium.org
>  
>  Change-Id: Ifaccc3374466b851fc28b10c63ed1397bdae635e
>  No-Presubmit: true
>  No-Tree-Checks: true
>  No-Try: true
>  Bug: 866610
>  Reviewed-on: https://chromium-review.googlesource.com/1239216
>  Reviewed-by: Frank Liberato \<liberato@chromium.org>
>  Commit-Queue: Frank Liberato \<liberato@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#593260}
>
PR 13156 applied with additional changes from upstream: 4eaebdf70cbbbac6b95d757c424a879c1f980dac
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b19db2da4eb
[wpt PR 13156] - Revert "bindings: Implement timers with V8Function", a=testonly
Result changes from PR not available.
https://hg.mozilla.org/mozilla-central/rev/6b19db2da4eb
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.