Closed Bug 1493411 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 13164 - [service-workers] Use asynchronous cleanup

Categories

(Core :: DOM: Service Workers, enhancement, P4)

Product:
Core
Component:
DOM: Service Workers
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 13164 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/13164 Details from upstream follow. Mike Pennisi <mike@mikepennisi.com> wrote: > [service-workers] Use asynchronous cleanup > > Previously, many tests un-registered service workers only after all > assertions had been satisfied. This meant that failing tests would not > un-register workers. In order to account for workers that persisted from > previous test failures, the tests included "setup" code to defensively > un-register such workers. > > The `Test#add_cleanup` method was recently extended to support > asynchronous "clean up" operations [1]. Use that API to schedule service > worker un-registration so that it occurs regardless of the result of > each test. > > [1] https://github.com/web-platform-tests/wpt/pull/8748 > > --- > > This patch is not intended to influence test results. To verify that, I used > the WPT CLI to run the affected tests in Chromium and Firefox, comparing the > summary it produced both on `master` and on this branch. > > Chromium on `master`: > > web-platform-test > ~~~~~~~~~~~~~~~~~ > Ran 145 checks (32 tests, 113 subtests) > Expected results: 120 > Unexpected results: 25 > test: 2 (2 timeout) > subtest: 23 (15 fail, 6 notrun, 2 timeout) > > Chromium with patch applied: > > web-platform-test > ~~~~~~~~~~~~~~~~~ > Ran 145 checks (32 tests, 113 subtests) > Expected results: 120 > Unexpected results: 25 > test: 2 (2 timeout) > subtest: 23 (15 fail, 6 notrun, 2 timeout) > > Firefox on `master`: > > web-platform-test > ~~~~~~~~~~~~~~~~~ > Ran 145 checks (32 tests, 113 subtests) > Expected results: 134 > Unexpected results: 11 > test: 2 (2 timeout) > subtest: 9 (6 fail, 1 notrun, 2 timeout) > > Firefox with patch applied: > > web-platform-test > ~~~~~~~~~~~~~~~~~ > Ran 145 checks (32 tests, 113 subtests) > Expected results: 134 > Unexpected results: 11 > test: 2 (2 timeout) > subtest: 9 (6 fail, 1 notrun, 2 timeout)
PR 13164 applied with additional changes from upstream: 3411e4bff0a7c875811e65398472cc6403619476
Component: web-platform-tests → DOM: Service Workers
Product: Testing → Core
Failed to get results from try push
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8e147fb6be5b [wpt PR 13164] - [service-workers] Use asynchronous cleanup, a=testonly
https://hg.mozilla.org/mozilla-central/rev/8e147fb6be5b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.