Closed
Bug 1493412
Opened 6 years ago
Closed 6 years ago
Remove warning-64.png on Windows
Categories
(Toolkit :: Themes, enhancement, P1)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
10.17 KB,
patch
|
ntim
:
review+
|
Details | Diff | Splinter Review |
Bug 1457781 left the HiDPI rule behind.
Attachment #9011208 -
Flags: review?(ntim.bugs)
|
Assignee | |
Updated•6 years ago
|
Priority: -- → P1
|
||
Comment 1•6 years ago
|
||
Comment on attachment 9011208 [details] [diff] [review]
patch
Review of attachment 9011208 [details] [diff] [review]:
-----------------------------------------------------------------
There are many more DevTools test references: https://searchfox.org/mozilla-central/search?q=warning-64.png&path=
Attachment #9011208 -
Flags: review?(ntim.bugs) → review+
|
|
Assignee | |
Comment 2•6 years ago
|
||
These tests continue to work fine since they don't seem to depend on actually loading the image.
|
|
||
Comment 3•6 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #2)
> These tests continue to work fine since they don't seem to depend on
> actually loading the image.
I'm not sure maintaining the dead URL is a good idea, as it might potentially confuse future engineers looking at these tests.
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6e2e9f42c4b
"Remove warning-64.png on Windows" r=ntim
Keywords: checkin-needed
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•