Closed Bug 1493426 Opened 2 years ago Closed 2 years ago

BrowserAction popup always opens as non-private tab

Categories

(WebExtensions :: Android, enhancement)

63 Branch
enhancement
Not set
normal

Tracking

(firefox64 verified)

VERIFIED FIXED
mozilla64
Tracking Status
firefox64 --- verified

People

(Reporter: Oriol, Assigned: Oriol)

References

Details

(Whiteboard: [priority:low])

Attachments

(2 files)

If I am in a private tab and I open some browserAction popup, I don't expect it to open as a non-private tab.

openExtensionPopupTab should check the privateness of the selected tab, and open the popup with the same value.

https://searchfox.org/mozilla-central/rev/21588b2a9824e0758fe11d10065e2c01ea9f32be/mobile/android/components/extensions/ext-utils.js#302-305

let {browser, id} = win.BrowserApp.selectedTab;
let isPrivate = PrivateBrowsingUtils.isBrowserPrivate(browser);
win.BrowserApp.addTab(popup, {
  selected: true,
  parentId: id,
  isPrivate,
})
See Also: → 1372178
Andreas this is probably a small fix - can we move forward with a fix?
Flags: needinfo?(abovens)
The fix in in comment 0, just needs a test. I can write one later this week when I have time.
Whiteboard: [priority:low]
Is this also implemented in desktop?
Flags: needinfo?(abovens)
On desktop there is no tab, but an actual popup panel:
https://mdn.mozillademos.org/files/15747/page_action_popup.png
( picture from https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Popups )

The popup panel's PBM state matches the window's PBM state on desktop.
Assignee: nobody → oriol-bugzilla
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/973fdd5f75cd
Respect tab privateness when opening browserAction popup. r=rpl
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/973fdd5f75cd
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Verified as fixed in latest Nightly on Android device(Samsung Galaxy S7).

I will attach a postfix video.
Status: RESOLVED → VERIFIED
Attached image Postfix video
You need to log in before you can comment on or make changes to this bug.