1493426 - BrowserAction popup always opens as non-private tab

Status: VERIFIED FIXED

(WebExtensions :: Android, enhancement)

Description

[Oriol Brufau [:Oriol]]

If I am in a private tab and I open some browserAction popup, I don't expect it to open as a non-private tab.

openExtensionPopupTab should check the privateness of the selected tab, and open the popup with the same value.

https://searchfox.org/mozilla-central/rev/21588b2a9824e0758fe11d10065e2c01ea9f32be/mobile/android/components/extensions/ext-utils.js#302-305

let {browser, id} = win.BrowserApp.selectedTab;
let isPrivate = PrivateBrowsingUtils.isBrowserPrivate(browser);
win.BrowserApp.addTab(popup, {
  selected: true,
  parentId: id,
  isPrivate,
})

Comment 1

[:sdaswani]

Andreas this is probably a small fix - can we move forward with a fix?

Comment 2

[Oriol Brufau [:Oriol]]

The fix in in comment 0, just needs a test. I can write one later this week when I have time.

Comment 3

[Andreas Bovens [:abovens]]

Is this also implemented in desktop?

Comment 4

[Rob Wu [:robwu]]

On desktop there is no tab, but an actual popup panel:
https://mdn.mozillademos.org/files/15747/page_action_popup.png
( picture from https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Popups )

The popup panel's PBM state matches the window's PBM state on desktop.

Comment 5

[Oriol Brufau [:Oriol]]

Attachment: Bug 1493426 - Respect tab privateness when opening browserAction popup. r=rpl

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/973fdd5f75cd
Respect tab privateness when opening browserAction popup. r=rpl

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/973fdd5f75cd

Comment 8

[Victor Carciu]

Verified as fixed in latest Nightly on Android device(Samsung Galaxy S7).

I will attach a postfix video.

Comment 9

[Victor Carciu]

Attachment: Postfix video