BrowserAction popup always opens as non-private tab

VERIFIED FIXED in Firefox 64

Status

VERIFIED FIXED
2 months ago
20 days ago

People

(Reporter: Oriol, Assigned: Oriol)

Tracking

63 Branch
mozilla64

Firefox Tracking Flags

(firefox64 verified)

Details

(Whiteboard: [priority:low])

Attachments

(2 attachments)

(Assignee)

Description

2 months ago
If I am in a private tab and I open some browserAction popup, I don't expect it to open as a non-private tab.

openExtensionPopupTab should check the privateness of the selected tab, and open the popup with the same value.

https://searchfox.org/mozilla-central/rev/21588b2a9824e0758fe11d10065e2c01ea9f32be/mobile/android/components/extensions/ext-utils.js#302-305

let {browser, id} = win.BrowserApp.selectedTab;
let isPrivate = PrivateBrowsingUtils.isBrowserPrivate(browser);
win.BrowserApp.addTab(popup, {
  selected: true,
  parentId: id,
  isPrivate,
})

Updated

2 months ago
See Also: → bug 1372178
Andreas this is probably a small fix - can we move forward with a fix?
Flags: needinfo?(abovens)
(Assignee)

Comment 2

a month ago
The fix in in comment 0, just needs a test. I can write one later this week when I have time.
Whiteboard: [priority:low]
Is this also implemented in desktop?
Flags: needinfo?(abovens)

Comment 4

a month ago
On desktop there is no tab, but an actual popup panel:
https://mdn.mozillademos.org/files/15747/page_action_popup.png
( picture from https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Popups )

The popup panel's PBM state matches the window's PBM state on desktop.
(Assignee)

Comment 5

a month ago
Created attachment 9016859 [details]
Bug 1493426 - Respect tab privateness when opening browserAction popup. r=rpl
(Assignee)

Updated

a month ago
Assignee: nobody → oriol-bugzilla
Status: NEW → ASSIGNED
(Assignee)

Updated

a month ago
Keywords: checkin-needed

Comment 6

a month ago
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/973fdd5f75cd
Respect tab privateness when opening browserAction popup. r=rpl
Keywords: checkin-needed

Comment 7

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/973fdd5f75cd
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64

Comment 8

20 days ago
Verified as fixed in latest Nightly on Android device(Samsung Galaxy S7).

I will attach a postfix video.
Status: RESOLVED → VERIFIED

Comment 9

20 days ago
Created attachment 9021551 [details]
Postfix video

Updated

20 days ago
status-firefox64: fixed → verified
You need to log in before you can comment on or make changes to this bug.