149347 - incorrect interface comment in header.html.tmpl

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

header.html.tmpl says it takes a "jscript" parameter, but it actually takes a
"javascript" parameter.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

Comment 2

[Jouni Heikniemi]

Comment on attachment 86453 [details] [diff] [review]
patch v1: fixes problem

2xr=jouni

Comment 3

[Jouni Heikniemi]

-> patch author (myk)

There's no reason for not checking this into the branch as well -> 2.16.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

At this point it's a question of whether a compelling reason exists to check
something in to the branch, not whether there's any reason not to, and this
patch has no compelling value for the branch. -> 2.18

Comment 5

[Jouni Heikniemi]

... apart from the fact that publishing software with out-of-date documentation
(very broadly interpreted) is simply bad. Sometimes it's hard to avoid, but this
particular change is so trivial...

Comment 6

[Gervase Markham [:gerv]]

Yes - it's a comment-only change, after all. If it were changing code, I would
agree with Myk.

Gerv

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Ok, you convinced me that I'm being silly.  Changing milestone back to 2.16 and
checked into the 2.16 branch and the tip:

Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v
 <--  header.html.tmpl
new revision: 1.5.2.6; previous revision: 1.5.2.5
done

Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v
 <--  header.html.tmpl
new revision: 1.12; previous revision: 1.11
done