Closed Bug 1493507 Opened Last year Closed Last year
Don't walk the rule tree three times from apply
46 bytes, text/x-phabricator-request
|Details | Review|
Just once is slow enough.
Comment on attachment 9011274 [details] Avoid walking the rule tree three times from apply_declarations. Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9011274 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/cf4cc2623a5b Avoid walking the rule tree three times from apply_declarations. r=xidorn
Noticed some perf improvements: == Change summary for alert #16099 (as of Mon, 24 Sep 2018 06:52:51 GMT) == Improvements: 4% stylebench osx-10-10 opt e10s stylo 18.65 -> 19.34 3% stylebench windows10-64 pgo e10s stylo 43.89 -> 45.21 3% stylebench linux64-qr opt e10s stylo 39.48 -> 40.59 3% stylebench windows10-64-qr opt e10s stylo 42.90 -> 44.07 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=16099
You need to log in before you can comment on or make changes to this bug.