Closed
Bug 1493507
Opened Last year
Closed Last year
Don't walk the rule tree three times from apply_declarations.
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Not set
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(1 file)
This seems to make talos happy: https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=51aca3907d07&framework=1&showOnlyImportant=1&selectedTimeRange=172800
|
Assignee | |
Comment 1•Last year
|
||
Just once is slow enough.
|
||
Comment 2•Last year
|
||
Comment on attachment 9011274 [details]
Avoid walking the rule tree three times from apply_declarations.
Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9011274 -
Flags: review+
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/cf4cc2623a5b Avoid walking the rule tree three times from apply_declarations. r=xidorn
|
||
Comment 4•Last year
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cf4cc2623a5b
Status: NEW → RESOLVED
Closed: Last year
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Noticed some perf improvements: == Change summary for alert #16099 (as of Mon, 24 Sep 2018 06:52:51 GMT) == Improvements: 4% stylebench osx-10-10 opt e10s stylo 18.65 -> 19.34 3% stylebench windows10-64 pgo e10s stylo 43.89 -> 45.21 3% stylebench linux64-qr opt e10s stylo 39.48 -> 40.59 3% stylebench windows10-64-qr opt e10s stylo 42.90 -> 44.07 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=16099
You need to log in
before you can comment on or make changes to this bug.
Description
•