1493507 - Don't walk the rule tree three times from apply_declarations.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

This seems to make talos happy:

  https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=51aca3907d07&framework=1&showOnlyImportant=1&selectedTimeRange=172800

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Avoid walking the rule tree three times from apply_declarations.

Just once is slow enough.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 9011274 [details]
Avoid walking the rule tree three times from apply_declarations.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf4cc2623a5b
Avoid walking the rule tree three times from apply_declarations. r=xidorn

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/cf4cc2623a5b

Comment 5

[Ionuț Goldan [:igoldan]]

Noticed some perf improvements:

== Change summary for alert #16099 (as of Mon, 24 Sep 2018 06:52:51 GMT) ==

Improvements:

  4%  stylebench osx-10-10 opt e10s stylo           18.65 -> 19.34
  3%  stylebench windows10-64 pgo e10s stylo        43.89 -> 45.21
  3%  stylebench linux64-qr opt e10s stylo          39.48 -> 40.59
  3%  stylebench windows10-64-qr opt e10s stylo     42.90 -> 44.07

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=16099