1493550 - Update MimeType.cpp to allow quoted empty string parameters (MimeSniffing PR #79).

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P5)

Description

[Thomas Wisniewski [:twisniewski]]

MimeSniff PR #79 now allows quoted empty string parameter values. This bug is about updating the standards-compliant implementation added in bug 1454590 to account for this change.

Comment 1

[Thomas Wisniewski [:twisniewski]]

I'm not seeing any worrying signs on a try-run, so I'll request a review on Phabricator: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8394269768383799fc26c00753e393c9d8d5d3ec

Comment 2

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1493550 - allow quoted empty mime parameters in MimeType.cpp, per MimeSniffing PR #79; r?hsivonen

allow quoted empty mime parameters in MimeType.cpp, per MimeSniffing PR #79

Comment 3

[Henri Sivonen (:hsivonen)]

Comment on attachment 9011333 [details]
Bug 1493550 - allow quoted empty mime parameters in MimeType.cpp, per MimeSniffing PR #79; r?hsivonen

Henri Sivonen (:hsivonen) has approved the revision.

Comment 4

[Thomas Wisniewski [:twisniewski]]

Did another try-run just to make sure it's still looking clear: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fe8f0c4c1f78adb15713731760e114db63b7efa

Requesting check-in.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fcab3faf315
allow quoted empty mime parameters in MimeType.cpp, per MimeSniffing PR #79; r=hsivonen

Comment 6

[Thomas Wisniewski [:twisniewski]]

Ouch, I'm sorry, I forgot to arc diff for my latest revision :S (Still not 100% used to Phabricator)

Should we back this out and try again with the latest version?

Comment 7

[Andreea Pavel [:apavel]]

Thomas i canceled the jobs on the previous land, did you make the necessary changes in phabricator?

Comment 8

[Thomas Wisniewski [:twisniewski]]

Yes, I just did that a moment ago. Please let me know if there's anything else.

Comment 9

[Andreea Pavel [:apavel]]

(In reply to Thomas Wisniewski [:twisniewski] from comment #8)
> Yes, I just did that a moment ago. Please let me know if there's anything
> else.

There is this: https://irccloud.mozilla.com/file/pocGL2K0/image.png

Comment 10

[Thomas Wisniewski [:twisniewski]]

Hmm. I'm not seeing any conflicts when I apply the patch to a local copy of moz-inbound, so I'm not sure what's going on there.

Not that I expect it to help, but I've done another quick arc diff to address nits the C++ static analysis checker found (that my local run of the checker didn't warn me about for some reason). Maybe a fresh copy of the patch won't be as troublesome?

Comment 11

[Andreea Pavel [:apavel]]

Let me try something :D

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/20faad8222c2
allow quoted empty mime parameters in MimeType.cpp, per MimeSniffing PR #79; r=hsivonen

Comment 13

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8143457980ac
Backed out changeset 2fcab3faf315 for missing arc diff CLOSED TREE

Comment 14

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/20faad8222c2