Update the ESLint builders to use the node toolchain rather than pre-installing node on the docker images

NEW
Assigned to

Status

task
P3
normal
9 months ago
3 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Depends on 1 bug)

Trunk
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Assignee

Description

9 months ago
In bug 1482435 we are making the ESLint source test use the NODEJS environment variable for the location of node.

At the moment, it is hard coded in the task to be the location to which node is extracted in the Docker file.

It would be nicer if we could use the node toolchain, and drop the pre-installed node on the Docker image - as a result, we'll also ensure we have the same version of node as the rest of the builders.
Assignee

Comment 1

9 months ago
Posted patch Initial WIPSplinter Review
This was the initial patch I had for getting this to work. The bit I couldn't workout was either:

a) how to get a pre-existing script to download, install & run correctly.

or

b) what commands to invoke to use the variables in the correct manner.

Tom, could you help me out here please?
Assignee: nobody → standard8
Flags: needinfo?(mozilla)
Assignee

Comment 2

9 months ago
Note: we should probably do this for both the eslint (mozlint.yml) and eslint-plugin-mozilla (mocha.yml) tasks.
Comment on attachment 9011838 [details]
Bug 1493997 : [taskgraph] Add support for fetching toolchains via fetch-content; r?gps

Gregory Szorc [:gps] has approved the revision.
Attachment #9011838 - Flags: review+
:Standard8 I've attached a patch that gets the toolchain extracted. I'm not entirely sure how you want to integrate with it after that.
Flags: needinfo?(mozilla)
Attachment #9011838 - Attachment description: Bug 1493610: [taskgraph] Add support for fetching toolchains via fetch-content; r?gps → Bug 1493997 : [taskgraph] Add support for fetching toolchains via fetch-content; r?gps
Attachment #9011838 - Attachment is obsolete: true
Assignee

Comment 7

9 months ago
Per discussion in phabricator, this really wants to wait until node_modules is vendored - to make it simpler to handle npm for the ESLint task (we probably won't need to).
Depends on: 1491028
Assignee

Updated

6 months ago
Priority: -- → P3
Assignee

Updated

3 months ago
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.