1493610 - Update the ESLint builders to use the node toolchain rather than pre-installing node on the docker images

Status: NEW

(Firefox Build System :: General, task, P3)

Description

[Mark Banner (:standard8)]

In bug 1482435 we are making the ESLint source test use the NODEJS environment variable for the location of node.

At the moment, it is hard coded in the task to be the location to which node is extracted in the Docker file.

It would be nicer if we could use the node toolchain, and drop the pre-installed node on the Docker image - as a result, we'll also ensure we have the same version of node as the rest of the builders.

Comment 1

[Mark Banner (:standard8)]

Attachment: Initial WIP

This was the initial patch I had for getting this to work. The bit I couldn't workout was either:

a) how to get a pre-existing script to download, install & run correctly.

or

b) what commands to invoke to use the variables in the correct manner.

Tom, could you help me out here please?

Comment 2

[Mark Banner (:standard8)]

Note: we should probably do this for both the eslint (mozlint.yml) and eslint-plugin-mozilla (mocha.yml) tasks.

Comment 3

[Tom Prince [:tomprince]]

Attachment: Bug 1493997 : [taskgraph] Add support for fetching toolchains via fetch-content; r?gps

Comment 4

[Tom Prince [:tomprince]]

Attachment: Bug 1493610: [eslint] Get node from toolchain task.

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 9011838 [details]
Bug 1493997 : [taskgraph] Add support for fetching toolchains via fetch-content; r?gps

Gregory Szorc [:gps] has approved the revision.

Comment 6

[Tom Prince [:tomprince]]

:Standard8 I've attached a patch that gets the toolchain extracted. I'm not entirely sure how you want to integrate with it after that.

Comment 7

[Mark Banner (:standard8)]

Per discussion in phabricator, this really wants to wait until node_modules is vendored - to make it simpler to handle npm for the ESLint task (we probably won't need to).

Comment 8

[Mark Banner (:standard8)]

Until we can unblock bug 1491028, I'm not going to be working towards this.

Note: this will also require vendoring of jsdoc/yarn before we can move forward with it: https://searchfox.org/mozilla-central/rev/1097f59d0bc17f6f8f805325c2f607e60cf0d26b/taskcluster/docker/lint/system-setup.sh#52,54-55