1493625 - Make locale RTL in bidi pseudo localization in LocaleService::IsAppLocaleRTL

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement, P3)

Description

[Axel Hecht [:Pike]]

https://searchfox.org/mozilla-central/rev/0640ea80fbc8d48f8b197cd363e2535c95a15eb3/intl/locale/LocaleService.cpp#417-427 governs if we lay out RTL or not.

We should add a check for the pseudo l10n pref, and see if it's bidi, and return True if it is.

Fly-by, we could move the GetAppLocaleAsBCP47 beneath the prefs checks.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Hah! Have been planning to get to this for a while. Good to have a motiation :)

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

We also should look into obsoleting `intl.uidirection` once we get pseudo strategies to be not affecting developer's productivity.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1493625 - Make LocaleService::IsAppLocaleRTL react to pseudo. r=jfkthame

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 9011548 [details]
Bug 1493625 - Make LocaleService::IsAppLocaleRTL react to pseudo. r=jfkthame

Francesco Lodolo [:flod] has approved the revision.

Comment 5

[Jonathan Kew [:jfkthame]]

Comment on attachment 9011548 [details]
Bug 1493625 - Make LocaleService::IsAppLocaleRTL react to pseudo. r=jfkthame

Jonathan Kew (:jfkthame) has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d624ee1b23d
Make LocaleService::IsAppLocaleRTL react to pseudo. r=flod,jfkthame

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/5d624ee1b23d