1493675 - Autocomplete popup is annoying when typing `function`

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

**Steps to reproduce**
1. Open the console
2. Type `func`
3. The autocomplete popup is displayed with `Function` (note the uppercase F).
4. Hit enter

**Actual results**

My input is now `Function`, which might be fine, but actually, I wanted to declare a new function, so I have to go back to the first letter and replace it with a lowercase f.

---

There's 2 way of fixing this:
 - quick and ugly: filter out "Function" from result when the input is all lowercase
 - nicer: return all the keywords from the autocomplete. Since lowercase items are displayed first, `function` will come before `Function` and the STR will work as I intended.

I'm leaning towards the second solution as it would be a really nice thing to have. But we may not have enough time to put this into 64, and if so, it would be nice to have a quick fix for that.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

So, it looks like there's no existing API to retrieve the list of JS keywords.
The list lives in https://searchfox.org/mozilla-central/source/js/src/frontend/ReservedWords.h, and is then processed with a python script [1] (see usage [2]) to generate the file being used by the engine [3]

We could use a similar approach to generate a JS file with all the keywords, which we could then easily use in DevTools code.


[1] https://searchfox.org/mozilla-central/source/js/src/frontend/GenerateReservedWords.py
[2] https://searchfox.org/mozilla-central/rev/881a3c5664ede5e08ee986d76433bc5c4b5680e6/js/src/moz.build#692-697
[3] https://searchfox.org/mozilla-central/source/__GENERATED__/js/src/frontend/ReservedWordsGenerated.h

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1493675 - Send JS keywords from webconsole's autocomplete service; r=julienw.

This patch adds a file containing an arrau of all the
JS keywords, extracted from js/src/frontend/ReservedWords.h.
The webconsole autocomplete service then load this array, and
send the matching keywords to the client.
Later, this file will be automatically generated at build time (
See Bug 1499005) in order to be kept in sinc with what the engine
defines.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

TRY looks okay https://treeherder.mozilla.org/#/jobs?repo=try&revision=68ce6d957adaa8fcad67b5b969c33f81198250cb

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1493675 - Generate an array of the javascript keywords; r=arai.

This list is generated from /js/src/frontend/ReservedWords.h,
which is already used on the platform to generate list of js
reserved words.
This list will be used in the console autocomplete code to
expose those keywords to the user.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/887b52d6d707
Generate an array of the javascript keywords; r=arai.
https://hg.mozilla.org/integration/autoland/rev/cc4cf7804458
Send JS keywords from webconsole's autocomplete service; r=julienw.

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/887b52d6d707
https://hg.mozilla.org/mozilla-central/rev/cc4cf7804458