1493781 - Add an example to IsBaseOf to indicate that it is reflexive

Status: RESOLVED FIXED

(Core :: MFBT, enhancement)

Description

[Andrew McCreight [:mccr8]]

Adding something to the comment on IsBaseOf would be nice:
  mozilla::IsBaseOf<A, A>::value is true;

I think this is a good example to have because my understanding is that a class is not derived from itself, and thus is not actually a base class of itself, so the name of this predicate is not accurate.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1493781 - Add a comment to IsBaseOf indicating that it is reflexive

IsBaseOf<A, A> holds despite the fact that a class is not actually a
base class of itself.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 9011568 [details]
Bug 1493781 - Add a comment to IsBaseOf indicating that it is reflexive

Nathan Froyd [:froydnj] has approved the revision.

Comment 3

[Andrew McCreight [:mccr8]]

FWIW, my confusion about this led me to write an incorrect patch for bug 1493276 and bug 1493226. (Though fortunately I caught this before putting the patches up for review.)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abff79205da2
Add a comment to IsBaseOf indicating that it is reflexive r=froydnj

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/abff79205da2