1493791 - Fix trivial calls to do_QueryInterface in XPCOM unit tests

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1493791 - Fix trivial calls to do_QueryInterface in XPCOM unit tests

In TestEventTargetQI.cpp, nsISerialEventTarget is a subtype of
nsIThreadPool, so we cannot QI from the latter to the former once
trivial QIs are banned. However, we still want to check if a QI to
nsISerialEventTarget does something, so I added an intermediate cast
up to nsISupports, and then QI from there. I wrapped that all up in a
templated function, because the code is a bit ugly, and used it
everywhere for uniformity, even though it is not always needed.

I fixed TestCOMPtr.cpp in the same way, by casting up to nsISupports.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 9011970 [details]
Bug 1493791 - Fix trivial calls to do_QueryInterface in XPCOM unit tests

Nathan Froyd [:froydnj] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fea096dd49df
Fix trivial calls to do_QueryInterface in XPCOM unit tests r=froydnj

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/fea096dd49df