1493812 - Build grcov in a toolchain task on Windows too

Status: RESOLVED FIXED

(Testing :: Code Coverage, enhancement)

Description

[Marco Castelluccio [:marco]]

In bug 1492159, we started building grcov in toolchain tasks for Linux and Mac. We should do the same for Windows.

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Part 1: Build grcov in a toolchain task on Windows too

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Part 2: Remove grcov-win-x86_64 fetch as it's no longer needed

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 9012931 [details] [diff] [review]
Part 1: Build grcov in a toolchain task on Windows too

Review of attachment 9012931 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/scripts/misc/build-grcov.sh
@@ +24,2 @@
>  
> +    export INCLUDE="$WIN_WORKSPACE/build/src/vs2017_15.4.2/VC/include;$WIN_WORKSPACE/build/src/vs2017_15.4.2/VC/atlmfc/include;$WIN_WORKSPACE/build/src/vs2017_15.4.2/SDK/Include/10.0.15063.0/ucrt;$WIN_WORKSPACE/build/src/vs2017_15.4.2/SDK/Include/10.0.15063.0/shared;$WIN_WORKSPACE/build/src/vs2017_15.4.2/SDK/Include/10.0.15063.0/um;$WIN_WORKSPACE/build/src/vs2017_15.4.2/SDK/Include/10.0.15063.0/winrt;$WIN_WORKSPACE/build/src/vs2017_15.4.2/DIA SDK/include"

Could we put these all on their own newline (either via multiple export calls or using a backslash)? Ditto for LIB and PATH.

Comment 4

[Marco Castelluccio [:marco]]

(In reply to Andrew Halberstadt [:ahal] from comment #3)
> Comment on attachment 9012931 [details] [diff] [review]
> Part 1: Build grcov in a toolchain task on Windows too
> 
> Review of attachment 9012931 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: taskcluster/scripts/misc/build-grcov.sh
> @@ +24,2 @@
> >  
> > +    export INCLUDE="$WIN_WORKSPACE/build/src/vs2017_15.4.2/VC/include;$WIN_WORKSPACE/build/src/vs2017_15.4.2/VC/atlmfc/include;$WIN_WORKSPACE/build/src/vs2017_15.4.2/SDK/Include/10.0.15063.0/ucrt;$WIN_WORKSPACE/build/src/vs2017_15.4.2/SDK/Include/10.0.15063.0/shared;$WIN_WORKSPACE/build/src/vs2017_15.4.2/SDK/Include/10.0.15063.0/um;$WIN_WORKSPACE/build/src/vs2017_15.4.2/SDK/Include/10.0.15063.0/winrt;$WIN_WORKSPACE/build/src/vs2017_15.4.2/DIA SDK/include"
> 
> Could we put these all on their own newline (either via multiple export
> calls or using a backslash)? Ditto for LIB and PATH.

I agree it makes sense, but I copied these over from other scripts building Rust tools and they're all using the same format.
I will file a follow-up bug to do this for all of the scripts at the same time for consistency, there might also be opportunity for sharing code between them rather than rewriting it multiple times.

Comment 5

[Marco Castelluccio [:marco]]

I've filed bug 1495823 for the deduplication.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddaebd2a173a
Build grcov in a toolchain task on Windows too. r=ahal
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b5a508d0783
Remove grcov-win-x86_64 fetch as it's no longer needed. r=ahal

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/15e1324d7bef
Update clang version used for the grcov Mac build. r=me

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/ddaebd2a173a
https://hg.mozilla.org/mozilla-central/rev/1b5a508d0783
https://hg.mozilla.org/mozilla-central/rev/15e1324d7bef