1493835 - Don't let GPU process to notify VR process shutdown when no GPUChild connection

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[Daosheng Mu[:daoshengmu]]

Bug 1485388 is not fixed all the issues. We should call GPUChild IPC function after making sure it is connected.

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1493835 - Don't notify VR process shutdown when no GPUChild connection.

MozReview-Commit-ID: ZXs6SldKcw

Comment 2

[:kip (Kearwood Gilbert)]

Comment on attachment 9011897 [details]
Bug 1493835 - Don't notify VR process shutdown when no GPUChild connection.

:kip (Kearwood Gilbert) has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8a5673c51ea
Don't notify VR process shutdown when no GPUChild connection. r=kip

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/b8a5673c51ea

Comment 5

[Daosheng Mu[:daoshengmu]]

Comment on attachment 9011897 [details]
Bug 1493835 - Don't notify VR process shutdown when no GPUChild connection.

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1485388

User impact if declined: The one piece of the fixed patch has been landed to FF63. This patch is also needed to uplift to FF63 to solve the issue completely. Otherwise, the crashes from Bug 1485388 will still happen.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): It just a conditional check to avoid messages be sent without the IPC channel.

String changes made/needed:

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9011897 [details]
Bug 1493835 - Don't notify VR process shutdown when no GPUChild connection.

Crash fix, uplift approved for 63 beta 13, thanks.

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/822408e3c78d