Can't enter "?" and "!" using MSPY on WinXP-SC

VERIFIED FIXED in mozilla1.0.1

Status

()

Core
Internationalization
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: Roy Yokoyama, Assigned: Roy Yokoyama)

Tracking

({intl})

Trunk
mozilla1.0.1
x86
Windows XP
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [adt2 RTM])

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
Spin off from 146844

On my XP (En XP + multi lang UI), using MSPY, I can't enter "?" and "!". I'm
using 06/04 1.0.0 branch build.

WM_IME_CHAR msg sends proper CP936 code point
and moz convert to correct unicode point.
'!'   0xa3 0xa1 ---> 0xff01 FULL WITH EXCLAMATION MARK
'?'   0xa3 0xbf ---> 0xff1f FULL WITH QUESTION MARK
and then pass it to DOM NS_KEY_PRESS event.
Both looks ok.
(Assignee)

Comment 1

16 years ago
accepting and nominating for nsbeta1
Status: NEW → ASSIGNED
Keywords: nsbeta1

Updated

16 years ago
Keywords: intl

Comment 2

16 years ago
nsbeta1+

Frank, please put adt value.
Keywords: nsbeta1 → nsbeta1+
(Assignee)

Comment 3

16 years ago
Created attachment 86537 [details] [diff] [review]
Processing WM_IME_CHAR 

Three things in the patch
1) We receive charcode (not keycode) for WM_IME_CHAR so we should
   turn the mIsShiftDown OFF.
2) From Microsoft online doc, we could receive a single byte char
   thru WM_IME_CHAR. Thus add |if (aByte1)| to make sure we create 
   a complete string
3) We should turn off ISC_SHOWUICOMPOSITIONWINDOW bit
   if we have have non Over-The-Spot IME.  I am surprised that
   the current implementation works.

shanjian: try this patch and please review?

Updated

16 years ago
Blocks: 141008
(Assignee)

Updated

16 years ago
Target Milestone: --- → mozilla1.0.1

Comment 4

16 years ago
Comment on attachment 86537 [details] [diff] [review]
Processing WM_IME_CHAR 

r=shanjian. (Who knows those undocumented IME behavior?!).
Attachment #86537 - Flags: review+

Comment 5

16 years ago
[adt2] since it stop chinese users type in daily commonly used characters from
major IME. 
Whiteboard: [adt2]
(Assignee)

Comment 6

16 years ago
brendan: please super review. Thanks
Comment on attachment 86537 [details] [diff] [review]
Processing WM_IME_CHAR 

sr=brendan@mozilla.org

/be
Attachment #86537 - Flags: superreview+
(Assignee)

Comment 8

16 years ago
checked into the trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Updated

16 years ago
Keywords: adt1.0.1, mozilla1.0.1

Comment 9

16 years ago
ruixu - can you pls verify this on the trunk? thanks!
Blocks: 143047
Keywords: approval
Whiteboard: [adt2] → [adt2 RTM]

Comment 10

16 years ago
I tested with 2002061204 trunk on SC WinXP, only MS PinYin IME3.0 works fine.
All other SC IMEs supported on SC WinXP doesn't work properly, still cannot 
enter puntuation marks, but entered some other characters. 

Since this bug is only for MSPY on WinXP-SC, so mark it as verified.
Status: RESOLVED → VERIFIED

Comment 11

16 years ago
adt1.0.1+ (on ADT's behalf) approval for checkin to the 1.0 branch, pending
Drivers approval. pls check this in on the 1.0 branch, then add the keyword
"fixed1.0.1".
Keywords: adt1.0.1 → adt1.0.1+
Comment on attachment 86537 [details] [diff] [review]
Processing WM_IME_CHAR 

Please land this on the 1.0.1 branch.  Once there, remove the
"mozilla1.0.1+" keyword, and add the "fixed1.0.1"
Attachment #86537 - Flags: approval+
Keywords: mozilla1.0.1 → mozilla1.0.1+

Comment 13

16 years ago
Please check this in asap and change the mozilla1.0.1+ keyword to fixed1.0.1
(Assignee)

Comment 14

16 years ago
checked into the 1.0 branch
Keywords: mozilla1.0.1+ → fixed1.0.1

Updated

16 years ago
Blocks: 146292
No longer blocks: 141008

Comment 15

16 years ago
Verified on branch 2002062408.
Keywords: fixed1.0.1 → verified1.0.1
You need to log in before you can comment on or make changes to this bug.