Spin off from 146844 On my XP (En XP + multi lang UI), using MSPY, I can't enter "?" and "!". I'm using 06/04 1.0.0 branch build. WM_IME_CHAR msg sends proper CP936 code point and moz convert to correct unicode point. '!' 0xa3 0xa1 ---> 0xff01 FULL WITH EXCLAMATION MARK '?' 0xa3 0xbf ---> 0xff1f FULL WITH QUESTION MARK and then pass it to DOM NS_KEY_PRESS event. Both looks ok.
accepting and nominating for nsbeta1
Status: NEW → ASSIGNED
Three things in the patch 1) We receive charcode (not keycode) for WM_IME_CHAR so we should turn the mIsShiftDown OFF. 2) From Microsoft online doc, we could receive a single byte char thru WM_IME_CHAR. Thus add |if (aByte1)| to make sure we create a complete string 3) We should turn off ISC_SHOWUICOMPOSITIONWINDOW bit if we have have non Over-The-Spot IME. I am surprised that the current implementation works. shanjian: try this patch and please review?
Comment on attachment 86537 [details] [diff] [review] Processing WM_IME_CHAR r=shanjian. (Who knows those undocumented IME behavior?!).
Attachment #86537 - Flags: review+
[adt2] since it stop chinese users type in daily commonly used characters from major IME.
brendan: please super review. Thanks
Comment on attachment 86537 [details] [diff] [review] Processing WM_IME_CHAR firstname.lastname@example.org /be
Attachment #86537 - Flags: superreview+
checked into the trunk
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
ruixu - can you pls verify this on the trunk? thanks!
I tested with 2002061204 trunk on SC WinXP, only MS PinYin IME3.0 works fine. All other SC IMEs supported on SC WinXP doesn't work properly, still cannot enter puntuation marks, but entered some other characters. Since this bug is only for MSPY on WinXP-SC, so mark it as verified.
Status: RESOLVED → VERIFIED
adt1.0.1+ (on ADT's behalf) approval for checkin to the 1.0 branch, pending Drivers approval. pls check this in on the 1.0 branch, then add the keyword "fixed1.0.1".
Comment on attachment 86537 [details] [diff] [review] Processing WM_IME_CHAR Please land this on the 1.0.1 branch. Once there, remove the "mozilla1.0.1+" keyword, and add the "fixed1.0.1"
Attachment #86537 - Flags: approval+
Please check this in asap and change the mozilla1.0.1+ keyword to fixed1.0.1
You need to log in before you can comment on or make changes to this bug.