149397 - Can't enter "?" and "!" using MSPY on WinXP-SC

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Roy Yokoyama]

Spin off from 146844

On my XP (En XP + multi lang UI), using MSPY, I can't enter "?" and "!". I'm
using 06/04 1.0.0 branch build.

WM_IME_CHAR msg sends proper CP936 code point
and moz convert to correct unicode point.
'!'   0xa3 0xa1 ---> 0xff01 FULL WITH EXCLAMATION MARK
'?'   0xa3 0xbf ---> 0xff1f FULL WITH QUESTION MARK
and then pass it to DOM NS_KEY_PRESS event.
Both looks ok.

Comment 1

[Roy Yokoyama]

accepting and nominating for nsbeta1

Comment 2

[nhottanscp]

nsbeta1+

Frank, please put adt value.

Comment 3

[Roy Yokoyama]

Attachment: Processing WM_IME_CHAR

Three things in the patch
1) We receive charcode (not keycode) for WM_IME_CHAR so we should
   turn the mIsShiftDown OFF.
2) From Microsoft online doc, we could receive a single byte char
   thru WM_IME_CHAR. Thus add |if (aByte1)| to make sure we create 
   a complete string
3) We should turn off ISC_SHOWUICOMPOSITIONWINDOW bit
   if we have have non Over-The-Spot IME.  I am surprised that
   the current implementation works.

shanjian: try this patch and please review?

Comment 4

[Shanjian Li]

Comment on attachment 86537 [details] [diff] [review]
Processing WM_IME_CHAR 

r=shanjian. (Who knows those undocumented IME behavior?!).

Comment 5

[Frank Tang]

[adt2] since it stop chinese users type in daily commonly used characters from
major IME. 

Comment 6

[Roy Yokoyama]

brendan: please super review. Thanks

Comment 7

[Brendan Eich [:brendan]]

Comment on attachment 86537 [details] [diff] [review]
Processing WM_IME_CHAR 

sr=[e-mail]

/be

Comment 8

[Roy Yokoyama]

checked into the trunk

Comment 9

[Jaime Rodriguez, Jr.]

ruixu - can you pls verify this on the trunk? thanks!

Comment 10

[Rui Xu]

I tested with 2002061204 trunk on SC WinXP, only MS PinYin IME3.0 works fine.
All other SC IMEs supported on SC WinXP doesn't work properly, still cannot 
enter puntuation marks, but entered some other characters. 

Since this bug is only for MSPY on WinXP-SC, so mark it as verified.

Comment 11

[Jaime Rodriguez, Jr.]

adt1.0.1+ (on ADT's behalf) approval for checkin to the 1.0 branch, pending
Drivers approval. pls check this in on the 1.0 branch, then add the keyword
"fixed1.0.1".

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 86537 [details] [diff] [review]
Processing WM_IME_CHAR 

Please land this on the 1.0.1 branch.  Once there, remove the
"mozilla1.0.1+" keyword, and add the "fixed1.0.1"

Comment 13

[scottputterman]

Please check this in asap and change the mozilla1.0.1+ keyword to fixed1.0.1

Comment 14

[Roy Yokoyama]

checked into the 1.0 branch

Comment 15

[Rui Xu]

Verified on branch 2002062408.