Closed Bug 1493980 Opened 3 years ago Closed 3 years ago
Crash in Internal
Orientation To Type
47 bytes, text/x-phabricator-request
|Details | Review|
This bug was filed from the Socorro interface and is report bp-833c5b4a-0f14-4f90-b23b-6f3e70180925. ============================================================= Seen while looking at beta Android crashes: https://bit.ly/2QWriXG. These crashes spiked a bit in 63b5. They are present in 62 as well, with ~49 crashes. Mix of devices ranging from API 28 down to API 19. moz_crash_reason = MOZ_CRASH(Bad aOrientation value) Top 10 frames of crashing thread: 0 libxul.so InternalOrientationToType dom/base/ScreenOrientation.cpp:49 1 libxul.so mozilla::dom::ScreenOrientation::ScreenOrientation dom/base/ScreenOrientation.cpp:80 2 libGLES_mali.so libGLES_mali.so@0xe3058 3 libxul.so nsScreen::nsScreen dom/base/nsScreen.cpp:40 4 libxul.so nsScreen::Create dom/base/nsScreen.cpp:34 5 libxul.so mbrtoc32 6 libGLES_mali.so libGLES_mali.so@0xeb50e 7 libxul.so nsGlobalWindowInner::GetScreen dom/base/nsGlobalWindowInner.cpp:2234 8 libGLES_mali.so libGLES_mali.so@0xeb50e 9 libxul.so mozilla::dom::Window_Binding::get_screen dom/bindings/WindowBinding.cpp:3132 =============================================================
Although the spike in b5 is noticeable, it appears only 5 installations were causing that amount of crashes. The crash continues into other betas but in fairly low volume.
snorp, do you know if things have changed recently in the Java-side for handling/sending orientation values?
We did change some stuff in bug 1476106 and followups. Jan, do you feel like taking a look at this?
Flags: needinfo?(snorp) → needinfo?(jh+bugzilla)
I can try taking a look.
I won't have the time to look at this in the near future, though, so if someone else wants to investigate feel free.
It's closer to 1000 crashes/600 installs per week on Fennec release. Fix-optional for 64 since we're getting close to the end of the cycle; we could still take a patch for 65.
This eliminates one potential source of crashes from passing bad orientation values to onOrientationChange.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/972a66d8aab1 Don't pass indefinite screen orientations to Gecko. r=snorp
You need to log in before you can comment on or make changes to this bug.