Use Element::GetFrame in XULMenuElement and XULPopupElement

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P5
normal
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: enndeakin, Assigned: enndeakin)

Tracking

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

8 months ago
No description provided.
Assignee

Comment 1

8 months ago
Assignee: nobody → enndeakin
Attachment #9012189 - Flags: review?(bzbarsky)
Assignee

Updated

8 months ago
Priority: -- → P5
Comment on attachment 9012189 [details] [diff] [review]
Use Element::GetFrame in XULMenuElement and XULPopupElement

>Bug 1494000, use Element::GetFrame in XULMenuElement and XULPopupElement, r=bz

GetPrimaryFrame, not GetFrame.

> XULPopupElement::GetOuterScreenRect()

This should get a MOZ_CAN_RUN_SCRIPT annotation.

> XULPopupElement::GetAlignmentPosition()

Same.

> XULPopupElement::AlignmentOffset()

Same.

> XULPopupElement::SetConstraintRect

Same.

r=me with those nits fixed.  Thank you!
Attachment #9012189 - Flags: review?(bzbarsky) → review+

Comment 3

7 months ago
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a22c1051967
use Element::GetFrame in XULMenuElement and XULPopupElement, r=bz

Comment 4

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4a22c1051967
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.