1494038 - Prefix REPORT_BUILD with relativesrcdir

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Michael Shal [:mshal]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1485081#c32, https://bugzilla.mozilla.org/show_bug.cgi?id=1485081#c39, and https://bugzilla.mozilla.org/show_bug.cgi?id=1485081#c40 for some background.

It would be helpful to print the relativesrcdir in REPORT_BUILD lines so that there is some indication which directory creates the generated file, program, library, etc.

For example, instead of:

ErrorNamesInternal.h.stub
libxul.so
dependentlibs.list.stub

This would become:

xpcom/base/ErrorNamesInternal.h.stub
toolkit/library/libxul.so
toolkit/library/dependentlibs.list.stub

Comment 1

[Michael Shal [:mshal]]

Attachment: Bug 1494038 - Prefix REPORT_BUILD with relativesrcdir; r?Build

This makes it more apparent which directory is responsible for creating
a particular generated file, program, library, etc. It is particularly
helpful in bug 1485081 since all node.py invocations will have similarly
named make targets, but run in different directories.

MozReview-Commit-ID: HlSOiL34i3M

Comment 2

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Comment on attachment 9011888 [details]
Bug 1494038 - Prefix REPORT_BUILD with relativesrcdir; r?Build

Nick Alexander :nalexander [he/him] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3960b5b2ccb
Prefix REPORT_BUILD with relativesrcdir; r=firefox-build-system-reviewers,nalexander

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/d3960b5b2ccb