1494077 - Can't compile a debug build using clang-cl and disable-jemalloc

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Jean-Yves Avenard [:jya]]

using this mozconfig:

	mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/../obj-ff-dbg       
															  
	ac_add_options --target=x86_64-pc-mingw32                 
	ac_add_options --host=x86_64-pc-mingw32                   
															  
	ac_add_options --enable-debug                            
	ac_add_options --enable-debug-symbols                     
	ac_add_options --enable-eme=widevine                      
															  
	#disable jemalloc for debugging memory overwrite          
	ac_add_options --disable-jemalloc                         
															  
	#remove if too slow                                       
	ac_add_options --disable-optimize                         
															  
	mk_add_options 'export CARGO_INCREMENTAL=1'               
															  
	export CC="clang-cl.exe"                                  
	export CXX="clang-cl.exe"                                 
	export LINKER=lld-link      

You get compilation error:
C:\PROGRA~2\MICROS~3\2017\COMMUN~1\VC\Tools\MSVC\1415~1.267\include\deque(335,3):  error: use of undeclared identifier 'L__func__'
 0:20.55                 _STL_VERIFY(_Mycont, "cannot increment value-initialized deque iterator");

Full error attached

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: logs.txt

Comment 2

[Jean-Yves Avenard [:jya]]

removing ac_add_options --disable-jemalloc    fix the proble, (but then you can't use asan)

Comment 3

[(Away)]

(In reply to Jean-Yves Avenard [:jya] from comment #2)
> removing ac_add_options --disable-jemalloc    fix the proble, (but then you
> can't use asan)

But our ASan (and ASan Nightly Reporter) builds in CI work fine -- strange!

Comment 4

[(Away)]

It's probably this: https://searchfox.org/mozilla-central/source/toolkit/components/places/nsPlacesMacros.h#10

Comment 5

[(Away)]

Attachment: Remove unused macro and its supporting #define to fix a unified build problem.

AIUI this code was originally written this way in order to work on all compilers, but VS supports __func__ natively now.

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 9011919 [details]
Remove unused macro and its supporting #define to fix a unified build problem.

Marco Bonardo [::mak] has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80e6c958c849
Remove unused macro and its supporting #define to fix a unified build problem. r=mak

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/80e6c958c849