Closed Bug 1494077 Opened 1 year ago Closed 1 year ago

Can't compile a debug build using clang-cl and disable-jemalloc

Categories

(Firefox Build System :: General, enhancement)

x86_64
Windows 10
enhancement
Not set

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: jya, Assigned: dmajor)

Details

Attachments

(2 files)

using this mozconfig:

	mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/../obj-ff-dbg       
															  
	ac_add_options --target=x86_64-pc-mingw32                 
	ac_add_options --host=x86_64-pc-mingw32                   
															  
	ac_add_options --enable-debug                            
	ac_add_options --enable-debug-symbols                     
	ac_add_options --enable-eme=widevine                      
															  
	#disable jemalloc for debugging memory overwrite          
	ac_add_options --disable-jemalloc                         
															  
	#remove if too slow                                       
	ac_add_options --disable-optimize                         
															  
	mk_add_options 'export CARGO_INCREMENTAL=1'               
															  
	export CC="clang-cl.exe"                                  
	export CXX="clang-cl.exe"                                 
	export LINKER=lld-link      

You get compilation error:
C:\PROGRA~2\MICROS~3\2017\COMMUN~1\VC\Tools\MSVC\1415~1.267\include\deque(335,3):  error: use of undeclared identifier 'L__func__'
 0:20.55                 _STL_VERIFY(_Mycont, "cannot increment value-initialized deque iterator");

Full error attached
Attached file logs.txt
removing ac_add_options --disable-jemalloc    fix the proble, (but then you can't use asan)
(In reply to Jean-Yves Avenard [:jya] from comment #2)
> removing ac_add_options --disable-jemalloc    fix the proble, (but then you
> can't use asan)

But our ASan (and ASan Nightly Reporter) builds in CI work fine -- strange!
AIUI this code was originally written this way in order to work on all compilers, but VS supports __func__ natively now.
Attachment #9011919 - Attachment description: Don't redefine __FUNCTION__ because it leads to a unified build problem → Remove unused macro and its supporting #define to fix a unified build problem.
Comment on attachment 9011919 [details]
Remove unused macro and its supporting #define to fix a unified build problem.

Marco Bonardo [::mak] has approved the revision.
Attachment #9011919 - Flags: review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80e6c958c849
Remove unused macro and its supporting #define to fix a unified build problem. r=mak
https://hg.mozilla.org/mozilla-central/rev/80e6c958c849
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Assignee: nobody → dmajor
You need to log in before you can comment on or make changes to this bug.