1494139 - Fixes to the tup backend for rust integration with spidermonkey

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Chris Manchester (limited bugmail, email directly)]

I realized when debugging something for bug 1490948 that there might be multiple versions of certain crates that all want to write a build script output file, so these can't all be written to the same directory because the package name might not be enough to disambiguate on its own. We can write them to each package's out dir instead.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

I have a few fixes for bug 1490948 I'd like to land here.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1494139 - Place build script outputs in each package's output directory in the tup backend.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1494139 - Link rust libraries into programs in the tup backend.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1494139 - Add rust build script outputs to the tup backend for upcoming cranelift crates.

Comment 5

[Michael Shal [:mshal]]

Comment on attachment 9012713 [details]
Bug 1494139 - Place build script outputs in each package's output directory in the tup backend.

Michael Shal [:mshal] has approved the revision.

Comment 6

[Michael Shal [:mshal]]

Comment on attachment 9012715 [details]
Bug 1494139 - Link rust libraries into programs in the tup backend.

Michael Shal [:mshal] has approved the revision.

Comment 7

[Michael Shal [:mshal]]

Comment on attachment 9012719 [details]
Bug 1494139 - Add rust build script outputs to the tup backend for upcoming cranelift crates.

Michael Shal [:mshal] has approved the revision.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd114fd7cf68
Place build script outputs in each package's output directory in the tup backend. r=mshal
https://hg.mozilla.org/integration/autoland/rev/23ebf9cc2c2d
Add rust build script outputs to the tup backend for upcoming cranelift crates. r=mshal
https://hg.mozilla.org/integration/autoland/rev/e3e005ca7ffa
Link rust libraries into programs in the tup backend. r=mshal

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/fd114fd7cf68
https://hg.mozilla.org/mozilla-central/rev/23ebf9cc2c2d
https://hg.mozilla.org/mozilla-central/rev/e3e005ca7ffa