Open Bug 1494208 Opened 6 years ago Updated 1 year ago

Write better tests for screenshot commands

Categories

(Testing :: Marionette Client and Harness, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: ato, Unassigned)

References

(Blocks 1 open bug)

Details

The existing tests for Take Screenshot and Take Element Screenshot
commands are fairly basic.  We could borrow some tests from
https://searchfox.org/mozilla-central/source/testing/marionette/harness/marionette_harness/tests/unit/test_screenshot.py
to improve the situation.
Assignee: nobody → ato
Blocks: webdriver
Priority: -- → P2
Depends on: 1431148
https://bugzilla.mozilla.org/show_bug.cgi?id=1431148 contains some
useful test utilities that is needed to start this work.
Jim, can you confirm for me what IEDriver’s behaviour is for the
Take Screenshot command?  Firefox will currently use the bounding
client rect of the document element, but I would’ve expected this
command to include the full viewport, even if the document itself
is smaller?
Flags: needinfo?(james.h.evans.jr)
Depends on: 1385706

I spoke to jimevans on IRC and he confirmed my suspicion, that we
use the viewport’s dimensions and do not clamp on the document
element’s bounding box.

This seems to also be confirmed with the patch in
https://bugzilla.mozilla.org/show_bug.cgi?id=1385706 that I just
reviewed, which will fix this underlying problem for us.

Flags: needinfo?(james.h.evans.jr)
Assignee: ato → nobody
Priority: P2 → P3
Severity: normal → S3
Product: Testing → Remote Protocol
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in before you can comment on or make changes to this bug.