1494224 - Cleanup a bit the different ways we have to prevent generated content creation

Status: NEW

(Core :: Layout, enhancement, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

I realized I never tried to land this patch, but that I probably should.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Refactor a bit the way we decide whether to allow generated content.

Just never compute ::before / ::after for SVG in the style system
itself.

All the SVG FCDatas already had DISALLOW_GENERATED_CONTENT, except
foreignObject, so only behavior change should be whether we allow generated
content in <svg:foreignObject> (which we'd start disallowing).

Other browsers also disallow generated content on <foreignObject> elements, so
this aligns with them as well (it's likely it was just an oversight from our
side).

This removes a few awkward boolean arguments.

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 9012080 [details]
Refactor a bit the way we decide whether to allow generated content.

Cameron McCormack (:heycam) has approved the revision.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:emilio, could you have a look please?

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Yeah, fails tests.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:emilio, could you have a look please?

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Can we teach the bot to not nag multiple times about the same patch?

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Calixte is the boss!

Comment 8

[Calixte Denizet (:calixte)]

I'll fix that, sorry for the noise.