1494378 - remove static_cast raw pointer in nsHttpTransaction splitting

Status: RESOLVED WONTFIX

(Core :: Networking: HTTP, enhancement, P3)

Description

[Junior [inactive]]

We should use do_QueryObject

Comment 1

[Junior [inactive]]

Attachment: Bug 1494378 - use QueryObject instead of casting a raw pointer

Comment 2

[Junior [inactive]]

need to followup
nsHttpTransaction on larch has ref count problem.
It has two mRefCnt_s from itself and nsAHttpTransactionShell.
Moreover, nsHttpTransaction has it's own version |Release|, making it more complicated.

Comment 3

[Junior [inactive]]

(In reply to Junior Hsu from comment #2)
> need to followup
> nsHttpTransaction on larch has ref count problem.
> It has two mRefCnt_s from itself and nsAHttpTransactionShell.
> Moreover, nsHttpTransaction has it's own version |Release|, making it more
> complicated.

This is not true. It's common to let subclasses use their own mRefCnt.
No need to change.

Comment 4

[Junior [inactive]]

splitted to bug 1497238 and bug 1485355