1494417 - [wpt-sync] Sync PR 13228 - Added whitespace test and template system fix for UTF-8 whitespace

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 13228 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13228
Details from upstream follow.

Andy Paicu <[e-mail]> wrote:
>  Added whitespace test and template system fix for UTF-8 whitespace
>  
>  Hi @foolip 
>  This is in relation to the whitespace issue in https://github.com/webcompat/web-bugs/issues/18902
>  
>  It contains a test (with some support files) and a small fix for the template system.
>  
>  Normally I would have fixed this is chrome and added a test and let it upstream naturally but unfortunately the test also requires a tiny fix to the template system to allow non-ASCII characters in the request GET dictionary so I had to submit a manual PR.
>  
>  I have run this test in chrome and firefox and the results are almost as expected. Interestingly enough, firefox allows NBSP (U+00A0) in between the directive name and value, but not inside the directive value which I believe will need fixing as it can't be right.
>  
>  Firefox
>  
>  PASS Should load image without any CSP - meta tag
>  PASS Should load image without any CSP - HTTP header
>  PASS Should not load image with 'none' CSP - meta tag
>  PASS Should not load image with 'none' CSP - HTTP header
>  PASS U+0009 TAB   should be properly parsed between directive name and value - meta tag
>  PASS U+0009 TAB   should be properly parsed between directive name and value - HTTP header
>  PASS U+000C FF    should be properly parsed between directive name and value - meta tag
>  PASS U+000C FF    should be properly parsed between directive name and value - HTTP header
>  PASS U+000A LF    should be properly parsed between directive name and value - meta tag
>  PASS U+000D CR    should be properly parsed between directive name and value - meta tag
>  PASS U+0020 SPACE should be properly parsed between directive name and value - meta tag
>  PASS U+0020 SPACE should be properly parsed between directive name and value - HTTP header
>  PASS U+0009 TAB   should be properly parsed inside directive value - meta tag
>  PASS U+0009 TAB   should be properly parsed inside directive value - HTTP header
>  PASS U+000C FF    should be properly parsed inside directive value - meta tag
>  PASS U+000C FF    should be properly parsed inside directive value - HTTP header
>  PASS U+000A LF    should be properly parsed inside directive value - meta tag
>  PASS U+000D CR    should be properly parsed inside directive value - meta tag
>  PASS U+0020 SPACE should be properly parsed inside directive value - meta tag
>  PASS U+0020 SPACE should be properly parsed inside directive value - HTTP header
>  FAIL U+00A0 NBSP  should be properly parsed between directive name and value - meta tag 
>  FAIL U+00A0 NBSP  should be properly parsed between directive name and value - HTTP header 
>  PASS U+00A0 NBSP  should be properly parsed inside directive value - meta tag
>  PASS U+00A0 NBSP  should be properly parsed inside directive value - HTTP header
>  
>  Chrome
>  PASS Should load image without any CSP - meta tag
>  PASS Should load image without any CSP - HTTP header
>  PASS Should not load image with 'none' CSP - meta tag
>  PASS Should not load image with 'none' CSP - HTTP header
>  PASS U+0009 TAB   should be properly parsed between directive name and value - meta tag
>  PASS U+0009 TAB   should be properly parsed between directive name and value - HTTP header
>  PASS U+000C FF    should be properly parsed between directive name and value - meta tag
>  PASS U+000C FF    should be properly parsed between directive name and value - HTTP header
>  PASS U+000A LF    should be properly parsed between directive name and value - meta tag
>  PASS U+000D CR    should be properly parsed between directive name and value - meta tag
>  PASS U+0020 SPACE should be properly parsed between directive name and value - meta tag
>  PASS U+0020 SPACE should be properly parsed between directive name and value - HTTP header
>  PASS U+0009 TAB   should be properly parsed inside directive value - meta tag
>  PASS U+0009 TAB   should be properly parsed inside directive value - HTTP header
>  PASS U+000C FF    should be properly parsed inside directive value - meta tag
>  PASS U+000C FF    should be properly parsed inside directive value - HTTP header
>  PASS U+000A LF    should be properly parsed inside directive value - meta tag
>  PASS U+000D CR    should be properly parsed inside directive value - meta tag
>  PASS U+0020 SPACE should be properly parsed inside directive value - meta tag
>  PASS U+0020 SPACE should be properly parsed inside directive value - HTTP header
>  FAIL U+00A0 NBSP  should be properly parsed between directive name and value - meta tag 
>  FAIL U+00A0 NBSP  should be properly parsed between directive name and value - HTTP header 
>  FAIL U+00A0 NBSP  should be properly parsed inside directive value - meta tag
>  FAIL U+00A0 NBSP  should be properly parsed inside directive value - HTTP header

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad92dd811cd5d5602550058ffe02032c91a9e1f2

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=977dc3b61648ab9ed347946c2d40b6f53a9aa16e

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 1 tests and 24 subtests
PASS   : 20
TIMEOUT: 5

New tests that have failures or other problems:
/content-security-policy/generic/only-valid-whitespaces-are-allowed.html: TIMEOUT
    U+00A0 NBSP  should not be parsed between directive name and value - HTTP header: TIMEOUT
    U+00A0 NBSP  should not be parsed between directive name and value - meta tag: TIMEOUT
    U+00A0 NBSP  should not be parsed inside directive value - HTTP header: TIMEOUT
    U+00A0 NBSP  should not be parsed inside directive value - meta tag: TIMEOUT

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf3a0dadbdb6
[wpt PR 13228] - Added whitespace test and template system fix for UTF-8 whitespace, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0f1204727e6
[wpt PR 13228] - Update wpt metadata, a=testonly

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/bf3a0dadbdb6
https://hg.mozilla.org/mozilla-central/rev/a0f1204727e6