Closed Bug 1494476 Opened Last year Closed 11 months ago

Require having had first-party interaction before being granted a first-party storage exception

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

(Keywords: dev-doc-complete)

Attachments

(5 files)

We should not be granting third-parties who have never had first-party interaction any first-party storage exceptions.
Priority: -- → P2
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/473362250320
Part 1: Make AntiTrackingCommon::AddFirstPartyStorageAccessGrantedFor() accept a principal argument instead of a string r=baku
https://hg.mozilla.org/integration/autoland/rev/3c38fad722a6
Part 2: Refactor calls to the storage access API into a helper script file r=baku
https://hg.mozilla.org/integration/autoland/rev/f89516a277dc
Part 3: Require having had first-party interaction before being granted a first-party storage exception r=baku
https://hg.mozilla.org/integration/autoland/rev/70d95bda8458
Part 4: Add tests for requiring interaction with a tracker in the first-party context before granting a third-party storage exception for it r=baku
Needs updating our documentation.  Steven, do you mind?  :-)  Thanks!
Flags: needinfo?(senglehardt)
Keywords: dev-doc-needed
Backed out 4 changesets (bug 1494476) for build bustage and linting failure. CLOSED TREE

Log:
NFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ --target=i686-linux-android -o nsUrlClassifierPrefixSet.o -c -flto=thin -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DMOZ_SAFEBROWSING_DUMP_FAILED_UPDATES -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/toolkit/components/url-classifier -I/builds/worker/workspace/build/src/obj-firefox/toolkit/components/url-classifier -I/builds/worker/workspace/build/src/toolkit/components/build -I/builds/worker/workspace/build/src/xpcom/io -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -isystem /builds/worker/workspace/build/src/android-ndk/sysroot/usr/include/i686-linux-android -isystem /builds/worker/workspace/build/src/android-ndk/sysroot/usr/include -gcc-toolchain /builds/worker/workspace/build/src/android-ndk/toolchains/x86-4.9/prebuilt/linux-x86_64 -D__ANDROID_API__=16 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-short-enums -fno-exceptions -I/builds/worker/workspace/build/src/android-ndk/sources/cxx-stl/llvm-libc++/include -I/builds/worker/workspace/build/src/android-ndk/sources/android/support/include -I/builds/worker/workspace/build/src/android-ndk/sources/cxx-stl/llvm-libc++abi/include -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -Oz -fno-omit-frame-pointer -funwind-tables -Werror -Wno-error=shadow -Wno-maybe-uninitialized  -MD -MP -MF .deps/nsUrlClassifierPrefixSet.o.pp   /builds/worker/workspace/build/src/toolkit/components/url-classifier/nsUrlClassifierPrefixSet.cpp
[task 2018-10-10T15:31:06.134Z] 15:31:06     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/url-classifier'
[task 2018-10-10T15:31:06.142Z] 15:31:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/ctypes'
[task 2018-10-10T15:31:06.142Z] 15:31:06     INFO -  mkdir -p '.deps/'
[task 2018-10-10T15:31:06.142Z] 15:31:06     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/ctypes'
[task 2018-10-10T15:31:06.142Z] 15:31:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/ctypes'
[task 2018-10-10T15:31:06.142Z] 15:31:06     INFO -  toolkit/components/ctypes
[task 2018-10-10T15:31:06.142Z] 15:31:06     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/ctypes'
[task 2018-10-10T15:31:06.143Z] 15:31:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/ctypes'
[task 2018-10-10T15:31:06.143Z] 15:31:06     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/ctypes'
[task 2018-10-10T15:31:06.224Z] 15:31:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/antitracking'
[task 2018-10-10T15:31:06.230Z] 15:31:06     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ --target=i686-linux-android -o Unified_cpp_antitracking0.o -c -flto=thin -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/toolkit/components/antitracking -I/builds/worker/workspace/build/src/obj-firefox/toolkit/components/antitracking -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -isystem /builds/worker/workspace/build/src/android-ndk/sysroot/usr/include/i686-linux-android -isystem /builds/worker/workspace/build/src/android-ndk/sysroot/usr/include -gcc-toolchain /builds/worker/workspace/build/src/android-ndk/toolchains/x86-4.9/prebuilt/linux-x86_64 -D__ANDROID_API__=16 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-short-enums -fno-exceptions -I/builds/worker/workspace/build/src/android-ndk/sources/cxx-stl/llvm-libc++/include -I/builds/worker/workspace/build/src/android-ndk/sources/android/support/include -I/builds/worker/workspace/build/src/android-ndk/sources/cxx-stl/llvm-libc++abi/include -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -Oz -fno-omit-frame-pointer -funwind-tables -Werror  -MD -MP -MF .deps/Unified_cpp_antitracking0.o.pp   /builds/worker/workspace/build/src/obj-firefox/toolkit/components/antitracking/Unified_cpp_antitracking0.cpp
[task 2018-10-10T15:31:06.230Z] 15:31:06     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/toolkit/components/antitracking/Unified_cpp_antitracking0.cpp:2:
[task 2018-10-10T15:31:06.230Z] 15:31:06     INFO -  /builds/worker/workspace/build/src/toolkit/components/antitracking/AntiTrackingCommon.cpp:451:8: error: use of undeclared identifier 'HasUserInteraction'
[task 2018-10-10T15:31:06.230Z] 15:31:06     INFO -    if (!HasUserInteraction(trackingPrincipal)) {
[task 2018-10-10T15:31:06.230Z] 15:31:06     INFO -         ^
[task 2018-10-10T15:31:06.230Z] 15:31:06     INFO -  1 error generated.
[task 2018-10-10T15:31:06.230Z] 15:31:06     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1118: recipe for target 'Unified_cpp_antitracking0.o' failed
[task 2018-10-10T15:31:06.230Z] 15:31:06     INFO -  make[4]: *** [Unified_cpp_antitracking0.o] Error 1
[task 2018-10-10T15:31:06.230Z] 15:31:06     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/antitracking'
[task 2018-10-10T15:31:06.230Z] 15:31:06     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'toolkit/components/antitracking/target' failed
[task 2018-10-10T15:31:06.230Z] 15:31:06     INFO -  make[3]: *** [toolkit/components/antitracking/target] Error 2
[task 2018-10-10T15:31:06.230Z] 15:31:06     INFO -  make[3]: *** Waiting for unfinished jobs....
[task 2018-10-10T15:31:06.231Z] 15:31:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-10-10T15:31:06.231Z] 15:31:06     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-10-10T15:31:06.233Z] 15:31:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-10-10T15:31:06.234Z] 15:31:06     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-10-10T15:31:06.471Z] 15:31:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/ctypes'
[task 2018-10-10T15:31:06.471Z] 15:31:06     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ --target=i686-linux-android -o ctypes.o -c -flto=thin -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/toolkit/components/ctypes -I/builds/worker/workspace/build/src/obj-firefox/toolkit/components/ctypes -I/builds/worker/workspace/build/src/js/xpconnect/loader -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -isystem /builds/worker/workspace/build/src/android-ndk/sysroot/usr/include/i686-linux-android -isystem /builds/worker/workspace/build/src/android-ndk/sysroot/usr/include -gcc-toolchain /builds/worker/workspace/build/src/android-ndk/toolchains/x86-4.9/prebuilt/linux-x86_64 -D__ANDROID_API__=16 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-short-enums -fno-exceptions -I/builds/worker/workspace/build/src/android-ndk/sources/cxx-stl/llvm-libc++/include -I/builds/worker/workspace/build/src/android-ndk/sources/android/support/include -I/builds/worker/workspace/build/src/android-ndk/sources/cxx-stl/llvm-libc++abi/include -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -Oz -fno-omit-frame-pointer -funwind-tables -Werror  -MD -MP -MF .deps/ctypes.o.pp   /builds/worker/workspace/build/src/toolkit/components/ctypes/ctypes.cpp
[task 2018-10-10T15:31:06.474Z] 15:31:06     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/ctypes'
[task 2018-10-10T15:31:06.490Z] 15:31:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-10-10T15:31:06.491Z] 15:31:06     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-10-10T15:31:06.491Z] 15:31:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-10-10T15:31:06.491Z] 15:31:06     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-10-10T15:31:06.540Z] 15:31:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/url-classifier'
[task 2018-10-10T15:31:06.540Z] 15:31:06     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ --target=i686-linux-android -o nsUrlClassifierStreamUpdater.o -c -flto=thin -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DMOZ_SAFEBROWSING_DUMP_FAILED_UPDATES -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/toolkit/components/url-classifier -I/builds/worker/workspace/build/src/obj-firefox/toolkit/components/url-classifier -I/builds/worker/workspace/build/src/toolkit/components/build -I/builds/worker/workspace/build/src/xpcom/io -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -isystem /builds/worker/workspace/build/src/android-ndk/sysroot/usr/include/i686-linux-android -isystem /builds/worker/workspace/build/src/android-ndk/sysroot/usr/include -gcc-toolchain /builds/worker/workspace/build/src/android-ndk/toolchains/x86-4.9/prebuilt/linux-x86_64 -D__ANDROID_API__=16 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-short-enums -fno-exceptions -I/builds/worker/workspace/build/src/android-ndk/sources/cxx-stl/llvm-libc++/include -I/builds/worker/workspace/build/src/android-ndk/sources/android/support/include -I/builds/worker/workspace/build/src/android-ndk/sources/cxx-stl/llvm-libc++abi/include -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -Oz -fno-omit-frame-pointer -funwind-tables -Werror -Wno-error=shadow -Wno-maybe-uninitialized  -MD -MP -MF .deps/nsUrlClassifierStreamUpdater.o.pp   /builds/worker/workspace/build/src/toolkit/components/url-classifier/nsUrlClassifierStreamUpdater.cpp
[task 2018-10-10T15:31:06.540Z] 15:31:06     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/url-classifier'
[task 2018-10-10T15:31:06.543Z] 15:31:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-10-10T15:31:06.543Z] 15:31:06     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-10-10T15:31:06.559Z] 15:31:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-10-10T15:31:06.559Z] 15:31:06     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-10-10T15:31:06.696Z] 15:31:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/xpfe/appshell'
[task 2018-10-10T15:31:06.698Z] 15:31:06     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ --target=i686-linux-android -o Unified_cpp_xpfe_appshell0.o -c -flto=thin -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/xpfe/appshell -I/builds/worker/workspace/build/src/obj-firefox/xpfe/appshell -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/xul -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -isystem /builds/worker/workspace/build/src/android-ndk/sysroot/usr/include/i686-linux-android -isystem /builds/worker/workspace/build/src/android-ndk/sysroot/usr/include -gcc-toolchain /builds/worker/workspace/build/src/android-ndk/toolchains/x86-4.9/prebuilt/linux-x86_64 -D__ANDROID_API__=16 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-short-enums -fno-exceptions -I/builds/worker/workspace/build/src/android-ndk/sources/cxx-stl/llvm-libc++/include -I/builds/worker/workspace/build/src/android-ndk/sources/android/support/include -I/builds/worker/workspace/build/src/android-ndk/sources/cxx-stl/llvm-libc++abi/include -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -Oz -fno-omit-frame-pointer -funwind-tables -Werror  -MD -MP -MF .deps/Unified_cpp_xpfe_appshell0.o.pp   /builds/worker/workspace/build/src/obj-firefox/xpfe/appshell/Unified_cpp_xpfe_appshell0.cpp
[task 2018-10-10T15:31:06.698Z] 15:31:06     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/xpfe/appshell'
[task 2018-10-10T15:31:06.698Z] 15:31:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-10-10T15:31:06.698Z] 15:31:06     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-10-10T15:31:06.699Z] 15:31:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-10-10T15:31:06.699Z] 15:31:06     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2018-10-10T15:31:06.817Z] 15:31:06     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=70d95bda84582be0a55cea86d5deafd19962a547

Backout:
https://hg.mozilla.org/integration/autoland/rev/68f1999b78a1bc6f33ce2fa9e578697cfd794c89
Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc1d49fd799c
Part 0: Add the HasUserInteraction function r=baku
https://hg.mozilla.org/integration/autoland/rev/8c191b926a43
Part 1: Make AntiTrackingCommon::AddFirstPartyStorageAccessGrantedFor() accept a principal argument instead of a string r=baku
https://hg.mozilla.org/integration/autoland/rev/84b8383192e2
Part 2: Refactor calls to the storage access API into a helper script file r=baku
https://hg.mozilla.org/integration/autoland/rev/a9d96c509598
Part 3: Require having had first-party interaction before being granted a first-party storage exception r=baku
https://hg.mozilla.org/integration/autoland/rev/0c6a935d5c0a
Part 4: Add tests for requiring interaction with a tracker in the first-party context before granting a third-party storage exception for it r=baku
Done (https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Privacy/Storage_access_policy$compare?from=1420458&to=1425538). We should also include this in the eventual Storage Access API docs.
Flags: needinfo?(senglehardt)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a60706c7063
follow-up: Remove the debugging console.log calls that crept in inside the part 2 patch
Flags: needinfo?(ehsan)
I've made sure the 30 days thing is mentioned clearly in the main landing page too. I think this is complete now.

https://developer.mozilla.org/en-US/docs/Web/API/Storage_Access_API
Duplicate of this bug: 1497192
See Also: → 1505568
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.