1494529 - kill #text-label binding

Status: RESOLVED FIXED

(Core :: XUL, task, P3)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

follow up bug 1448213 comment #32

Comment 1

[alexander :surkov (:asurkov)]

note, the patch is based on patch from bug 1494230

Comment 2

[alexander :surkov (:asurkov)]

2nd note, accessKey used to return a first character of @accessKey attribute, now it returns a whole string similar to what HTMLElement does. It seems to be a safe change, since appears the code doesn't have dependencies on it.

Comment 3

[Olli Pettay [:smaug]]

Comment on attachment 9012459 [details] [diff] [review]
patch


>diff --git a/dom/xul/XULTextElement.h b/dom/xul/XULTextElement.h
>--- a/dom/xul/XULTextElement.h
>+++ b/dom/xul/XULTextElement.h
>@@ -33,16 +33,24 @@ public:
>   MOZ_CAN_RUN_SCRIPT void GetValue(DOMString& aValue) const
>   {
>     GetXULAttr(nsGkAtoms::value, aValue);
>   }
>   MOZ_CAN_RUN_SCRIPT void SetValue(const nsAString& aValue)
>   {
>     SetAttr(kNameSpaceID_None, nsGkAtoms::value, aValue, true);
>   }
>+  MOZ_CAN_RUN_SCRIPT void GetAccessKey(DOMString& aValue) const
>+  {
How can this run a script
Drop the annotation or exlain

Comment 4

[alexander :surkov (:asurkov)]

(In reply to Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.) from comment #3)

> >   MOZ_CAN_RUN_SCRIPT void GetValue(DOMString& aValue) const
> >   {
> >     GetXULAttr(nsGkAtoms::value, aValue);
> >   }
> >   MOZ_CAN_RUN_SCRIPT void SetValue(const nsAString& aValue)
> >   {
> >     SetAttr(kNameSpaceID_None, nsGkAtoms::value, aValue, true);
> >   }
> >+  MOZ_CAN_RUN_SCRIPT void GetAccessKey(DOMString& aValue) const
> >+  {
> How can this run a script
> Drop the annotation or exlain

dropped

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/181d337b15bd
kill #text-label binding, r=smaug

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/181d337b15bd