kill #text-label binding

RESOLVED FIXED in Firefox 64

Status

()

P3
normal
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
Posted patch patchSplinter Review
follow up bug 1448213 comment #32
Attachment #9012459 - Flags: review?(bugs)
(Assignee)

Comment 1

6 months ago
note, the patch is based on patch from bug 1494230
(Assignee)

Comment 2

6 months ago
2nd note, accessKey used to return a first character of @accessKey attribute, now it returns a whole string similar to what HTMLElement does. It seems to be a safe change, since appears the code doesn't have dependencies on it.
Depends on: 1494230
Priority: -- → P3
Comment on attachment 9012459 [details] [diff] [review]
patch


>diff --git a/dom/xul/XULTextElement.h b/dom/xul/XULTextElement.h
>--- a/dom/xul/XULTextElement.h
>+++ b/dom/xul/XULTextElement.h
>@@ -33,16 +33,24 @@ public:
>   MOZ_CAN_RUN_SCRIPT void GetValue(DOMString& aValue) const
>   {
>     GetXULAttr(nsGkAtoms::value, aValue);
>   }
>   MOZ_CAN_RUN_SCRIPT void SetValue(const nsAString& aValue)
>   {
>     SetAttr(kNameSpaceID_None, nsGkAtoms::value, aValue, true);
>   }
>+  MOZ_CAN_RUN_SCRIPT void GetAccessKey(DOMString& aValue) const
>+  {
How can this run a script
Drop the annotation or exlain
Attachment #9012459 - Flags: review?(bugs) → review+
(Assignee)

Comment 4

6 months ago
(In reply to Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.) from comment #3)

> >   MOZ_CAN_RUN_SCRIPT void GetValue(DOMString& aValue) const
> >   {
> >     GetXULAttr(nsGkAtoms::value, aValue);
> >   }
> >   MOZ_CAN_RUN_SCRIPT void SetValue(const nsAString& aValue)
> >   {
> >     SetAttr(kNameSpaceID_None, nsGkAtoms::value, aValue, true);
> >   }
> >+  MOZ_CAN_RUN_SCRIPT void GetAccessKey(DOMString& aValue) const
> >+  {
> How can this run a script
> Drop the annotation or exlain

dropped

Comment 6

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/181d337b15bd
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.