1494538 - Update accelerated features when GPU process is disabled

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Sotaro Ikeda [:sotaro]]

When GPU process is disabled, it does not update accelerated features. Then current gecko always fallback to BasicCompositor in this case.

Comment 1

[Sotaro Ikeda [:sotaro]]

During fallback to BasicCompositor, some graphic errors are printed by trying D3D Compositor.

They are like the following.

(#0) Error	Failed to connect GPU process
(#1) Error	[D3D11] failed to get compositor device.
(#2) Error	[D3D11] Failed to init compositor with reason: FEATURE_FAILURE_D3D11_NO_DEVICE
(#3) 	CP+[GFX1-]: Could not get a DXGI adapter
(#4) 	CP+[GFX1-]: Could not get a DXGI adapter
(#5) 	CP+[GFX1-]: Could not get a DXGI adapter
(#6) Error	[D3D11] failed to get compositor device.
(#7) Error	[D3D11] Failed to init compositor with reason: FEATURE_FAILURE_D3D11_NO_DEVICE

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Update accelerated features when GPU process is disabled

Comment 3

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8578834b0d1fcc3168eac75b7674730f2cb53bd2

Comment 4

[Matt Woodrow (:mattwoodrow)]

Isn't it intentional that we fallback to BasicCompositor when the GPU process has failed repeatedly?

The assumption is that something in the graphics driver is crashing, so we don't want to run it in the parent process, since then it would crash the whole browser.

Is that different from what this is trying to do?

Comment 5

[Sotaro Ikeda [:sotaro]]

Yea, it seems like intentional to fallback to BasicCompositor. In this case, it seems better to make it explicitly. gecko does not make it explicitly and tries to allocate D3D compositor and then failed and fallbacks to BasicCompositor.

Comment 6

[Sotaro Ikeda [:sotaro]]

During disabling GPU process, GPUProcessManager only disables HW_COMPOSITING if the GPU process is disabled by DeviceReset in GPU Process.

GPUProcessManager::OnRemoteProcessDeviceReset()
https://dxr.mozilla.org/mozilla-central/source/gfx/ipc/GPUProcessManager.cpp#505

Comment 7

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #6)
> During disabling GPU process, GPUProcessManager only disables HW_COMPOSITING
> if the GPU process is disabled by DeviceReset in GPU Process.

But gecko virtually disabling HW_COMPOSITING because compositor device does not exist in parent process.

Comment 8

[Sotaro Ikeda [:sotaro]]

It seems that some code expects to initialize D3DDevice.

nsWindow::GetLayerManager() calls gfxWindowsPlatform::UpdateRenderMode() before creating Compositor. But it does not work as to create D3DDevice.
  https://dxr.mozilla.org/mozilla-central/source/widget/windows/nsWindow.cpp#3956

But the UpdateRenderMode() does not create D3DDevice. The D3DDevice is created only when device reset happens. It is done by gfxWindowsPlatform::HandleDeviceReset().
  https://dxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxWindowsPlatform.cpp#404

HandleDeviceReset() was added by Bug 1183910. Then always fallback to BasicCompositor during disabling GPU process seems to continued about 3 years.

Comment 9

[Sotaro Ikeda [:sotaro]]

Then it seems better just explicitly fallback to software for now in this case.

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fallback to sofware when GPU process is disabled on Windows

Comment 11

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 9012823 [details] [diff] [review]
patch - Fallback to sofware when GPU process is disabled on Windows

Review of attachment 9012823 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/ipc/GPUProcessManager.cpp
@@ +196,5 @@
>    // crash, then we need to tell the content processes again, because they
>    // need to rebind to the UI process.
>    HandleProcessLost();
> +
> +  // On windos, always fallback to software.

Windows

Comment 12

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fallback to sofware when GPU process is disabled on Windows

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/948d251c50ee
Fallback to sofware when GPU process is disabled on Windows r=mattwoodrow

Comment 14

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/948d251c50ee