1494589 - Extend PERMISSION_REQUEST_* probe lifetime

Status: RESOLVED FIXED

(Firefox :: Site Identity, enhancement, P1)

Description

[Johann Hofmann [:johannh]]

We have a bunch of work in progress that benefits from or needs these measurements (bug 1483631, bug 1429432), so it makes sense to keep these around a little longer.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1494589 - Extend PERMISSION_REQUEST_* probe lifetime. r=florian,data-r=chutten

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 9012521 [details]
Bug 1494589 - Extend PERMISSION_REQUEST_* probe lifetime. r=florian,data-r=chutten

Florian Quèze [:florian] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55be882db711
Extend PERMISSION_REQUEST_* probe lifetime. r=florian

Comment 4

[Jan-Erik Rediger [:janerik]]

Extending a probe's lifetime requires a new data review.
Please file a data review request, see https://wiki.mozilla.org/Firefox/Data_Collection#Requesting_Data_Collection

Comment 5

[Johann Hofmann [:johannh]]

Gah, was this changed? I remember getting told that I don't need this on previous data reviews. That wiki page also doesn't mention the case.

I'll request backout...

Comment 6

[Raul Gurzau (:RaulG)]

Backed out changeset 55be882db711 (Bug 1494589) at developer's request

Backout link: https://hg.mozilla.org/integration/autoland/rev/4b08331584c1c052189c41e4de02ef0edf5a2556

Comment 7

[Chris H-C :chutten]

I have filed https://github.com/mozilla/data-review/issues/12 to track that it isn't clear from the wiki what does and doesn't require review.

For the record, all new and changed data collection requires review.

Comment 8

[Johann Hofmann [:johannh]]

Chris, are you going to sign this off or is there any issue?

Thanks!

Comment 9

[Chris H-C :chutten]

Where is the data collection review request form? Is it on another bug?

Comment 10

[Johann Hofmann [:johannh]]

Attachment: request.md

Comment 11

[Chris H-C :chutten]

Comment on attachment 9015825 [details]
request.md

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. Standard Telemetry mechanisms apply.

    Is there a control mechanism that allows the user to turn the data collection on and off? 

Yes. Standard Telemetry mechanisms apply.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

N/A, expires in 70.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction

    Is the data collection request for default-on or default-off?

Default on for prerelease only.

    Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

    Is the data collection covered by the existing Firefox privacy notice? 

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :johannh is responsible for removing or renewing the probe before it expires in Firefox 70.

---
Result: datareview+

Comment 12

[Johann Hofmann [:johannh]]

Thanks!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5162ce7f1c51
Extend PERMISSION_REQUEST_* probe lifetime. r=florian,data-r=chutten

Comment 14

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/5162ce7f1c51