1494604 - Figure out what to do with nsSVGUtils::NotifyAncestorsOfFilterRegionChange

Status: RESOLVED FIXED

(Core :: SVG, enhancement, P3)

Description

[Jonathan Watt [:jwatt]]

nsSVGUtils::NotifyAncestorsOfFilterRegionChange simply walks the (SVG-only) parent chain, essentially dispatching restyle events with nsChangeHint_UpdateOverflow for each ancestor.

However, the only caller of this function is nsSVGDisplayContainerFrame::RemoveFrame, and it already dispatches an nsChangeHint_UpdateOverflow for the frame that's being removed (and overflow changes should bubble up through the ancestors when they're calculated). Maybe that gets discarded if the element itself is being removed? In any case, surely then we'd just need to dispatch nsChangeHint_UpdateOverflow for the parent frame, not every ancestor.

If the NotifyAncestorsOfFilterRegionChange isn't doing anything useful, we should remove it. If it is necessary, we should comment why.

Comment 1

[Jonathan Watt [:jwatt]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b709f125dcc761dec3153df7026ee0568d888d02

Comment 2

[Jonathan Watt [:jwatt]]

The NotifyAncestorsOfFilterRegionChange code was originally added in bug 421584. Since then we seem to have removed all other consumers except for the call in nsSVGDisplayContainerFrame::RemoveFrame.

Comment 3

[Jonathan Watt [:jwatt]]

It looks like removing this doesn't cause any failures on Try.

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: Bug 1494604. Remove nsSVGUtils::NotifyAncestorsOfFilterRegionChange. r?longsonr

Comment 5

[Robert Longson [:longsonr]]

Comment on attachment 9012558 [details]
Bug 1494604. Remove nsSVGUtils::NotifyAncestorsOfFilterRegionChange. r?longsonr

Robert Longson [:longsonr] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2073ec5bcc4e
Remove nsSVGUtils::NotifyAncestorsOfFilterRegionChange. r=longsonr

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2073ec5bcc4e