Closed Bug 1494608 Opened Last year Closed Last year

Frame Construction markers take so much time for marker allocation

Categories

(Core :: Gecko Profiler, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: canova, Assigned: canova)

Details

Attachments

(1 file)

Currently we have both markers and profiling labels for frame construction. But in a Slack conversation, jesup said that the profiler_tracing method takes over %10 of time in the frame constructions and he can't take a very long sample of Speedometer without it taking forever to load the profile. It's because there are so many ContentAppended/Removed markers in the profile. We should remove the markers and keep the profiling labels instead.

See the profiles:
http://bit.ly/2N2Dhjj
http://bit.ly/2N6OWhj
Markers are taking so much time(~10%) to allocate and in a website
like Speedometer, it takes ages to load the profile data since
there are so many frame construction markers.
Comment on attachment 9012546 [details]
Bug 1494608 - Remove the frame construction markers r?mstange

Markus Stange [:mstange] has approved the revision.
Attachment #9012546 - Flags: review+
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/797e2b29748f
Remove the frame construction markers r=mstange
https://hg.mozilla.org/mozilla-central/rev/797e2b29748f
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.