Closed Bug 1494648 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 13241 - [Unified Plan] Remote MediaStreamTracks should be muted by default.

Categories

(Core :: WebRTC, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 13241 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13241
Details from upstream follow.

Henrik Boström <hbos@chromium.org> wrote:
>  [Unified Plan] Remote MediaStreamTracks should be muted by default.
>  
>  Per-spec, tracks that are created with a receiver (e.g. addTrack or
>  setRemoteDescription) are muted by default. Prior to this CL they were
>  unmuted by default, whether or not they were receiving any packets.
>  
>  A correct implementation should unmute the tracks when RTP packets
>  arrive. We are not quite there yet, this CL assumes that if the receiver
>  becomes active through renegotiation it will unmute. We are careful to
>  make sure that the track is muted on the "ontrack" event so that the
>  application has time to wire up the "onunmute" event.
>  
>  By unmuting as part of processing SDP we fix the Unified Plan bug where
>  a remote track that had previously been muted was not unmuted when
>  becoming active again (transciever.currentDirection == 'sendrecv' or
>  'recvonly'), https://crbug.com/884023.
>  
>  This CL also makes "ontrack" fire synchronously per-spec,
>  https://crbug.com/788558. Note that some stream events still fire
>  asynchronously, which means they now fire after the "ontrack" event in
>  the Unified Plan case. This is remaining work on that bug.
>  
>  A new file is created to test muting related behaviors, and some helper
>  functions used this and another file are moved to
>  RTCPeerConnection-helper.js.
>  
>  Bug: 884023, 777619, 788558
>  Change-Id: I8dc3e2adf04e72282f085779639edc73bacfc86b
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1249066
>  WPT-Export-Revision: 998ccf852e2a08154042950c1930bfaeeda0386d
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Component: web-platform-tests → WebRTC
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 49 tests and 801[linux32-debug], 802[linux32-opt,linux64-debug,linux64-opt] subtests
OK     : 44
PASS   : 486[linux32-debug], 487[linux32-opt,linux64-debug,linux64-opt]
FAIL   : 309
TIMEOUT: 4
NOTRUN : 4

New tests that have failures or other problems:
/webrtc/RTCPeerConnection-remote-track-mute.https.html: TIMEOUT
    Changing transceiver direction to 'inactive' mutes the remote track: TIMEOUT
    Changing transceiver direction to 'sendrecv' unmutes the remote track: NOTRUN
    pc.close() mutes remote tracks: NOTRUN

Tests that are disabled for instability:
/webrtc/RTCDTMFSender-ontonechange.https.html
/webrtc/RTCPeerConnection-setRemoteDescription-answer.html
/webrtc/RTCPeerConnection-setRemoteDescription-offer.html
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb1d335ae21b
[wpt PR 13241] - [Unified Plan] Remote MediaStreamTracks should be muted by default., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f9995d90aff
[wpt PR 13241] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/cb1d335ae21b
https://hg.mozilla.org/mozilla-central/rev/7f9995d90aff
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.